diff mbox series

[1/2] clk: zynqmp: Check the return type

Message ID 1594311873-8683-1-git-send-email-shubhrajyoti.datta@xilinx.com (mailing list archive)
State Changes Requested, archived
Headers show
Series [1/2] clk: zynqmp: Check the return type | expand

Commit Message

Shubhrajyoti Datta July 9, 2020, 4:24 p.m. UTC 
Currently the return value of of_clk_add_hw_provider is ignored.
lets check and return value.

Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
---
 drivers/clk/zynqmp/clkc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Stephen Boyd July 10, 2020, 11:45 p.m. UTC | #1 
Quoting Shubhrajyoti Datta (2020-07-09 09:24:32)
> Currently the return value of of_clk_add_hw_provider is ignored.

Write of_clk_add_hw_provider() to indicate it's a function.

> lets check and return value.
> 
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
diff mbox series

Patch

diff --git a/drivers/clk/zynqmp/clkc.c b/drivers/clk/zynqmp/clkc.c
index db8d0d7..5f674c5 100644
--- a/drivers/clk/zynqmp/clkc.c
+++ b/drivers/clk/zynqmp/clkc.c
@@ -739,9 +739,7 @@  static int zynqmp_clk_setup(struct device_node *np)
 	zynqmp_register_clocks(np);
 
 	zynqmp_data->num = clock_max_idx;
-	of_clk_add_hw_provider(np, of_clk_hw_onecell_get, zynqmp_data);
-
-	return 0;
+	return of_clk_add_hw_provider(np, of_clk_hw_onecell_get, zynqmp_data);
 }
 
 static int zynqmp_clock_probe(struct platform_device *pdev)