| Message ID | 1620122886-13349-1-git-send-email-shubhrajyoti.datta@xilinx.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | clk: zynqmp: Check the return type | expand |
Quoting Shubhrajyoti Datta (2021-05-04 03:08:06) > Currently the return value of of_clk_add_hw_provider is ignored. > lets check and return value. > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > --- > drivers/clk/zynqmp/clkc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/clk/zynqmp/clkc.c b/drivers/clk/zynqmp/clkc.c > index db8d0d7..5f674c5 100644 > --- a/drivers/clk/zynqmp/clkc.c > +++ b/drivers/clk/zynqmp/clkc.c > @@ -739,9 +739,7 @@ static int zynqmp_clk_setup(struct device_node *np) > zynqmp_register_clocks(np); > > zynqmp_data->num = clock_max_idx; > - of_clk_add_hw_provider(np, of_clk_hw_onecell_get, zynqmp_data); > - > - return 0; > + return of_clk_add_hw_provider(np, of_clk_hw_onecell_get, zynqmp_data); Please free allocations on error. Also it would be useful to inline this whole function into the probe function and then use devm. With all that done this patch will become superb! I'm looking forward to it. > } > > static int zynqmp_clock_probe(struct platform_device *pdev) > -- > 2.1.1 >
diff --git a/drivers/clk/zynqmp/clkc.c b/drivers/clk/zynqmp/clkc.c index db8d0d7..5f674c5 100644 --- a/drivers/clk/zynqmp/clkc.c +++ b/drivers/clk/zynqmp/clkc.c @@ -739,9 +739,7 @@ static int zynqmp_clk_setup(struct device_node *np) zynqmp_register_clocks(np); zynqmp_data->num = clock_max_idx; - of_clk_add_hw_provider(np, of_clk_hw_onecell_get, zynqmp_data); - - return 0; + return of_clk_add_hw_provider(np, of_clk_hw_onecell_get, zynqmp_data); } static int zynqmp_clock_probe(struct platform_device *pdev)
Currently the return value of of_clk_add_hw_provider is ignored. lets check and return value. Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> --- drivers/clk/zynqmp/clkc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)