| Message ID | 20160908173651.769b6829@endymion (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | Stephen Boyd |
| Headers | show |
On 09/08/2016 08:36 AM, Jean Delvare wrote: > The sunxi-ng clock driver is useless for other architectures. > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > Cc: Maxime Ripard <maxime.ripard@free-electrons.com> > Cc: Michael Turquette <mturquette@baylibre.com> > --- > drivers/clk/sunxi-ng/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-4.8-rc5.orig/drivers/clk/sunxi-ng/Kconfig 2016-09-04 23:31:46.000000000 +0200 > +++ linux-4.8-rc5/drivers/clk/sunxi-ng/Kconfig 2016-09-08 17:29:46.179508283 +0200 > @@ -1,6 +1,6 @@ > config SUNXI_CCU > bool "Clock support for Allwinner SoCs" > - default ARCH_SUNXI > + depends on ARCH_SUNXI || COMPILE_TEST Please leave the default there and just add the depends and compile test part.
On Thu, 8 Sep 2016 12:32:07 -0700, Stephen Boyd wrote: > On 09/08/2016 08:36 AM, Jean Delvare wrote: > > The sunxi-ng clock driver is useless for other architectures. > > > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > > Cc: Maxime Ripard <maxime.ripard@free-electrons.com> > > Cc: Michael Turquette <mturquette@baylibre.com> > > --- > > drivers/clk/sunxi-ng/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- linux-4.8-rc5.orig/drivers/clk/sunxi-ng/Kconfig 2016-09-04 23:31:46.000000000 +0200 > > +++ linux-4.8-rc5/drivers/clk/sunxi-ng/Kconfig 2016-09-08 17:29:46.179508283 +0200 > > @@ -1,6 +1,6 @@ > > config SUNXI_CCU > > bool "Clock support for Allwinner SoCs" > > - default ARCH_SUNXI > > + depends on ARCH_SUNXI || COMPILE_TEST > > Please leave the default there and just add the depends and compile test > part. Yes, makes sense sorry. Will send v2 shortly. Thanks for the review,
--- linux-4.8-rc5.orig/drivers/clk/sunxi-ng/Kconfig 2016-09-04 23:31:46.000000000 +0200 +++ linux-4.8-rc5/drivers/clk/sunxi-ng/Kconfig 2016-09-08 17:29:46.179508283 +0200 @@ -1,6 +1,6 @@ config SUNXI_CCU bool "Clock support for Allwinner SoCs" - default ARCH_SUNXI + depends on ARCH_SUNXI || COMPILE_TEST if SUNXI_CCU
The sunxi-ng clock driver is useless for other architectures. Signed-off-by: Jean Delvare <jdelvare@suse.de> Cc: Maxime Ripard <maxime.ripard@free-electrons.com> Cc: Michael Turquette <mturquette@baylibre.com> --- drivers/clk/sunxi-ng/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)