From patchwork Thu Feb 16 17:55:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 9579217 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EA6A76049F for ; Fri, 17 Feb 2017 08:42:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E2ECB28580 for ; Fri, 17 Feb 2017 08:42:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D79EC28608; Fri, 17 Feb 2017 08:42:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=2.0 tests=BAYES_00, DATE_IN_PAST_12_24, RCVD_IN_DNSWL_HI,T_TVD_MIME_EPI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 65BEC28580 for ; Fri, 17 Feb 2017 08:42:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755778AbdBQIjJ (ORCPT ); Fri, 17 Feb 2017 03:39:09 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:60884 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754108AbdBQIjH (ORCPT ); Fri, 17 Feb 2017 03:39:07 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id BA20120B98; Fri, 17 Feb 2017 09:39:04 +0100 (CET) Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 963CF20706; Fri, 17 Feb 2017 09:39:04 +0100 (CET) Date: Thu, 16 Feb 2017 18:55:53 +0100 From: Maxime Ripard To: Bob Ham Cc: Chen-Yu Tsai , Michael Turquette , Stephen Boyd , stable@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: sunxi-ng: sun6i: Fix enable bit offset for hdmi-ddc module clock Message-ID: <20170216175553.epqbtjdazj76tjyu@lukather> References: <20170214022332.13326-1-wens@csie.org> <1487110855.7145.46.camel@settrans.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1487110855.7145.46.camel@settrans.net> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Bob, On Tue, Feb 14, 2017 at 10:20:55PM +0000, Bob Ham wrote: > On Tue, 2017-02-14 at 10:23 +0800, Chen-Yu Tsai wrote: > > The enable bit offset for the hdmi-ddc module clock is wrong. It is > > pointing to the main hdmi module clock enable bit. > > > > Reported-by: Bob Ham > > Fixes: c6e6c96d8fa6 ("clk: sunxi-ng: Add A31/A31s clocks") > > Cc: stable@vger.kernel.org # 4.9.x- > > Signed-off-by: Chen-Yu Tsai > > --- > > > > Hi Bob, > > > > Can you try this patch and see if it fixes your HDMI issue? > > With the kernel running without "clk_ignore_unused" that is. > > Hi Chen-Yu, > > Unfortunately, that doesn't fix it; I get the same behaviour as without > clk_ignore_unused. can you apply that patch and give us your kernel boot logs? Thanks! ------8<--------- -------8<------- diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 820a939fb6bb..0a23b03ea393 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -773,7 +773,9 @@ static void clk_disable_unused_subtree(struct clk_core *core) if (core->enable_count) goto unlock_out; - if (core->flags & CLK_IGNORE_UNUSED) + printk("Ignoring %s\n", core->name); + + if (true) goto unlock_out; /*