From patchwork Tue Jun 20 00:18:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 9798263 X-Patchwork-Delegate: sboyd@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9D37960328 for ; Tue, 20 Jun 2017 00:19:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 82E9123E64 for ; Tue, 20 Jun 2017 00:19:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 75404274D2; Tue, 20 Jun 2017 00:19:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C76F423E64 for ; Tue, 20 Jun 2017 00:19:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752607AbdFTAS5 (ORCPT ); Mon, 19 Jun 2017 20:18:57 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:48954 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752598AbdFTASz (ORCPT ); Mon, 19 Jun 2017 20:18:55 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 14E23607F4; Tue, 20 Jun 2017 00:18:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1497917935; bh=w1uoldutl1/r4zJJpJv0LKRDNEk3ueyYSnzKRHTxm5E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UkBH55YUZBa4ZlSZhhKMdT6oH8QKI1klGVimbcg3fh9ElStpSqbEVIg1NcXvbQdJt wyykbCIyFRtAg+yCuMFtwznxCWOkRX5L7fBbS+D9MVsSFkCAWyoeWx7ywagBBlpCmi 58iXY1/WLnjZiLoTY6dHocQn0Lp2JJMgqUZBE/cc= Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: sboyd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E85A860730; Tue, 20 Jun 2017 00:18:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1497917934; bh=w1uoldutl1/r4zJJpJv0LKRDNEk3ueyYSnzKRHTxm5E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SaZuQd32a1rjiAIgQAvtI+Dr54V+qi7yXuOIkG9pZXvy0uIr33Iar2+v9QEL72niG BbHL5pqguYAkzZ2S3/AbE1POkxQtGGof62FZqHJeWKjOkPEMMthu1Ug0TzUDVyLCKl p/Zc4l/114XvgBQOlnPpqYjtnG7RTrRikThamago= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E85A860730 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Mon, 19 Jun 2017 17:18:53 -0700 From: Stephen Boyd To: Gregory CLEMENT Cc: Mike Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Rob Herring , devicetree@vger.kernel.org, Nadav Haklai , Kostya Porotchkin , Neta Zur Hershkovits , Marcin Wojtas , Omri Itach , Shadi Ammouri Subject: Re: [GIT PULL] Improve cp110 clk support on Marvell Armada 7K/8K Message-ID: <20170620001853.GT20170@codeaurora.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 06/19, Gregory CLEMENT wrote: > > Hi Mike, Stephen, > > This time I turned the series in a pull request so I removed the > device tree binding part which will be in an other series for Rob > Herring and I also removed the dt part that I will take care of once > you will have pulled this one. > > I hope this will be easier for you to apply this way. > Ok. It wasn't clear what was going on and I forgot to ask in the lastest patch series. Pulled into clk-next, but I had to apply this patch on top: ---8<---- From: Stephen Boyd Subject: [PATCH] clk: mvebu: cp110: Minor cleanups Mark an array of strings static const and remove the dereference of a function pointer when assigning to the platform driver probe struct member. drivers/clk/mvebu/cp110-system-controller.c:89:12: warning: symbol 'gate_base_names' was not declared. Should it be static? drivers/clk/mvebu/cp110-system-controller.c:447:18: error: cannot dereference this type Signed-off-by: Stephen Boyd --- drivers/clk/mvebu/cp110-system-controller.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/clk/mvebu/cp110-system-controller.c b/drivers/clk/mvebu/cp110-system-controller.c index b034b79345ec..ca9a0a536174 100644 --- a/drivers/clk/mvebu/cp110-system-controller.c +++ b/drivers/clk/mvebu/cp110-system-controller.c @@ -86,7 +86,7 @@ enum { #define CP110_GATE_EIP150 25 #define CP110_GATE_EIP197 26 -const char *gate_base_names[] = { +static const char * const gate_base_names[] = { [CP110_GATE_AUDIO] = "audio", [CP110_GATE_COMM_UNIT] = "communit", [CP110_GATE_NAND] = "nand", @@ -437,14 +437,13 @@ static int cp110_clk_probe(struct platform_device *pdev) return cp110_syscon_common_probe(pdev, pdev->dev.of_node->parent); } - static const struct of_device_id cp110_syscon_legacy_of_match[] = { { .compatible = "marvell,cp110-system-controller0", }, { } }; static struct platform_driver cp110_syscon_legacy_driver = { - .probe = *cp110_syscon_legacy_clk_probe, + .probe = cp110_syscon_legacy_clk_probe, .driver = { .name = "marvell-cp110-system-controller0", .of_match_table = cp110_syscon_legacy_of_match,