From patchwork Wed Jun 21 17:45:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 9802413 X-Patchwork-Delegate: sboyd@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0611360234 for ; Wed, 21 Jun 2017 17:45:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E61A5285BA for ; Wed, 21 Jun 2017 17:45:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DA7AA2863A; Wed, 21 Jun 2017 17:45:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 01591285BA for ; Wed, 21 Jun 2017 17:45:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752657AbdFURpn (ORCPT ); Wed, 21 Jun 2017 13:45:43 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60494 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752472AbdFURpn (ORCPT ); Wed, 21 Jun 2017 13:45:43 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 6FCA2601A0; Wed, 21 Jun 2017 17:45:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1498067142; bh=kdTKKbMeTbzEgD58ovaKnddgbjih5+eZNVDkcZM0YFo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lMQAFRecsSzHQX4rNTaV5WYrOdmlmMKBdgAY5LcgAlqQdwQ1Xi2n39hl45Uv9FXo5 FguJxOpxR4zC2lHl3/NrQF0v+ojpL2zIXfvWNQByIj/Bmo3VvAmBWZsACvTeH5b84L Da2tYD2f5/SKHUVDIRvEApJkTZUj/ZYttmdtXTPg= Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: sboyd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 46B33601A0; Wed, 21 Jun 2017 17:45:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1498067141; bh=kdTKKbMeTbzEgD58ovaKnddgbjih5+eZNVDkcZM0YFo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S3mnSdTJ4X5hSLKVv5uPK8LJ0HzkjBuMa3NYRHX7EN5lANuxiKTMeCG0xSsjBPckT mpNLDGG9ANv5jnvsah6GLZsnTgl+cecrZHhhJlTUgh45NGu9p+EW2WVQqC4/LVNtUy QGmCUv5q8cRKf9CADnzqlfRbDwtisnqrjCFdzBFU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 46B33601A0 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 21 Jun 2017 10:45:40 -0700 From: Stephen Boyd To: Linus Walleij Cc: Michael Turquette , Philipp Zabel , linux-clk@vger.kernel.org, Janos Laube , Paulius Zaleckas , linux-arm-kernel@lists.infradead.org, Hans Ulli Kroll , Florian Fainelli Subject: Re: [PATCH v8] clk: Add Gemini SoC clock controller Message-ID: <20170621174540.GB4493@codeaurora.org> References: <20170621075952.26387-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170621075952.26387-1-linus.walleij@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 06/21, Linus Walleij wrote: > The Cortina Systems Gemini (SL3516/CS3516) has an on-chip clock > controller that derive all clocks from a single crystal, using some > documented and some undocumented PLLs, half dividers, counters and > gates. This is a best attempt to construct a clock driver for the > clocks so at least we can gate off unused hardware and driver the > PCI bus clock. > > Acked-by: Philipp Zabel > Signed-off-by: Linus Walleij > --- Applied to clk-next + this fixup ---8<--- diff --git a/drivers/clk/clk-gemini.c b/drivers/clk/clk-gemini.c index 3ddd2faec674..b82db96ce0c7 100644 --- a/drivers/clk/clk-gemini.c +++ b/drivers/clk/clk-gemini.c @@ -279,13 +279,9 @@ static int gemini_clk_probe(struct platform_device *pdev) /* Remap the system controller for the exclusive register */ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -ENODEV; base = devm_ioremap_resource(dev, res); - if (!base) { - dev_err(dev, "no memory base\n"); - return -ENODEV; - } + if (IS_ERR(base)) + return PTR_ERR(base); map = syscon_node_to_regmap(np); if (IS_ERR(map)) {