From patchwork Sat Nov 10 20:31:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Kemnade X-Patchwork-Id: 10677407 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DC8EB14BD for ; Sat, 10 Nov 2018 20:31:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C21372BFDF for ; Sat, 10 Nov 2018 20:31:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B3CA32C00A; Sat, 10 Nov 2018 20:31:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 883EA2BFDF for ; Sat, 10 Nov 2018 20:31:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725979AbeKKGRv (ORCPT ); Sun, 11 Nov 2018 01:17:51 -0500 Received: from mail.andi.de1.cc ([85.214.239.24]:55176 "EHLO h2641619.stratoserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725846AbeKKGRv (ORCPT ); Sun, 11 Nov 2018 01:17:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=References:In-Reply-To:Message-Id:Date:Subject: Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bkT6Tvgpqv1f+bqR/z7UZurhOG3dEwgC/MQ7DiTqGn0=; b=as+EzBEVbE5PEBH8tav8ZjqVh OWO73h29oavst3j58voN17vUJlsDtdfWuwhc5M3QxZjXvU9ENM6XBoVAY3fnXQs19PNJrcYii+0ba zAgQtYDGwPfYVeQhLrrlB9aLDS/3yhILf60GRIYIWRe9XNSQXWGOGAOjDZxYJpQIEWkcA=; Received: from p200300ccfbcefb001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:fbce:fb00:1a3d:a2ff:febf:d33a] helo=aktux) by h2641619.stratoserver.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gLZul-0000Ay-UL; Sat, 10 Nov 2018 21:31:32 +0100 Received: from andi by aktux with local (Exim 4.89) (envelope-from ) id 1gLZul-0003Ts-L2; Sat, 10 Nov 2018 21:31:31 +0100 From: Andreas Kemnade To: t-kristo@ti.com, mturquette@baylibre.com, sboyd@kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, bcousson@baylibre.com, paul@pwsan.com, tony@atomide.com, letux-kernel@openphoenux.org Cc: Andreas Kemnade Subject: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops Date: Sat, 10 Nov 2018 21:31:14 +0100 Message-Id: <20181110203115.13335-3-andreas@kemnade.info> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181110203115.13335-1-andreas@kemnade.info> References: <20181110203115.13335-1-andreas@kemnade.info> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Code might use autoidle api with clocks not being omap2 clocks, so check if clock type is not basic Signed-off-by: Andreas Kemnade --- New in v2 --- drivers/clk/ti/autoidle.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/clk/ti/autoidle.c b/drivers/clk/ti/autoidle.c index 161f67850393..5bdae5552d38 100644 --- a/drivers/clk/ti/autoidle.c +++ b/drivers/clk/ti/autoidle.c @@ -54,8 +54,12 @@ static DEFINE_SPINLOCK(autoidle_spinlock); int omap2_clk_deny_idle(struct clk *clk) { struct clk_hw_omap *c; + struct clk_hw *hw = __clk_get_hw(clk); - c = to_clk_hw_omap(__clk_get_hw(clk)); + if (clk_hw_get_flags(hw) & CLK_IS_BASIC) + return -EINVAL; + + c = to_clk_hw_omap(hw); if (c->ops && c->ops->deny_idle) { unsigned long irqflags; @@ -77,8 +81,12 @@ int omap2_clk_deny_idle(struct clk *clk) int omap2_clk_allow_idle(struct clk *clk) { struct clk_hw_omap *c; + struct clk_hw *hw = __clk_get_hw(clk); - c = to_clk_hw_omap(__clk_get_hw(clk)); + if (clk_hw_get_flags(hw) & CLK_IS_BASIC) + return -EINVAL; + + c = to_clk_hw_omap(hw); if (c->ops && c->ops->allow_idle) { unsigned long irqflags;