| Message ID | 20181113111633.20189-27-jagan@amarulasolutions.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | drm/sun4i: Allwinner A64 MIPI-DSI support | expand |
On Tue, 13 Nov 2018 16:46:33 +0530 Jagan Teki <jagan@amarulasolutions.com> wrote: Hi, I couldn't find a schematic for this board, but some things in here look inconsistent: > Amarula A64-Relic board by default bound with Techstar TS8550B > MIPI-DSI panel, add support for it. > > DSI panel connected via board DSI port with, > - DC1SW as AVDD supply > - DCDC2 as DVDD supply Are you sure of that? That's typically the CPU power supply. Also I can't find it below. Should that read DLDO2 instead? > - DCDC1 as VCC-DSI supply Can't find this below, either. Is it DLDO1? > - PD24 gpio for reset pin > - PD23 gpio for backlight enable pin > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > .../allwinner/sun50i-a64-amarula-relic.dts | 46 > +++++++++++++++++++ 1 file changed, 46 insertions(+) > > diff --git > a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts index > 6cb2b7f0c817..ecc0d8094815 100644 --- > a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts +++ > b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts @@ -9,6 > +9,7 @@ #include "sun50i-a64.dtsi" > #include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/pwm/pwm.h> > > / { > model = "Amarula A64-Relic"; > @@ -18,6 +19,14 @@ > serial0 = &uart0; > }; > > + backlight: backlight { > + compatible = "pwm-backlight"; > + pwms = <&pwm 0 50000 PWM_POLARITY_INVERTED>; > + brightness-levels = <1 2 4 8 16 32 64 128 512>; > + default-brightness-level = <2>; > + enable-gpios = <&pio 3 23 GPIO_ACTIVE_HIGH>; /* > LCD-BL-EN: PD23 */ > + }; > + > chosen { > stdout-path = "serial0:115200n8"; > }; > @@ -30,6 +39,28 @@ > }; > }; > > +&de { > + status = "okay"; > +}; > + > +&dphy { > + status = "okay"; > +}; > + > +&dsi { > + vcc-dsi-supply = <®_dldo1>; Ah, there we have the SoC DSI power supply I was missing for the BPi-M64 patch. But is it DLDO1 or DCDC1, like you wrote above? > + status = "okay"; > + > + panel@0 { > + compatible = "techstar,ts8550b"; > + reg = <0>; > + avdd-supply = <®_dc1sw>; > + dvdd-supply = <®_dldo2>; > + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* > LCD-RST: PD24 */ > + backlight = <&backlight>; > + }; > +}; > + > &ehci0 { > status = "okay"; > }; > @@ -72,6 +103,12 @@ > status = "okay"; > }; > > +&pwm { > + pinctrl-names = "default"; > + pinctrl-0 = <&pwm_pin>; > + status = "okay"; > +}; > + > &r_rsb { > status = "okay"; > > @@ -107,6 +144,15 @@ > regulator-name = "vcc-pll-avcc"; > }; > > +®_dc1sw { > + /* > + * This regulator also indirectly drives the PD pingroup > GPIOs, > + * which also controls the power LED. > + */ Is that true for this board as well or is this just a copy&paste leftover from the BananaPi-M64? If not, you should loose the regulator-always-on property. > + regulator-always-on; > + regulator-name = "vcc-phy"; Shouldn't this be called "vcc-dsi" or so? Cheers, Andre. > +}; > + > ®_dcdc1 { > regulator-always-on; > regulator-min-microvolt = <3300000>;
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts index 6cb2b7f0c817..ecc0d8094815 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts @@ -9,6 +9,7 @@ #include "sun50i-a64.dtsi" #include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/pwm/pwm.h> / { model = "Amarula A64-Relic"; @@ -18,6 +19,14 @@ serial0 = &uart0; }; + backlight: backlight { + compatible = "pwm-backlight"; + pwms = <&pwm 0 50000 PWM_POLARITY_INVERTED>; + brightness-levels = <1 2 4 8 16 32 64 128 512>; + default-brightness-level = <2>; + enable-gpios = <&pio 3 23 GPIO_ACTIVE_HIGH>; /* LCD-BL-EN: PD23 */ + }; + chosen { stdout-path = "serial0:115200n8"; }; @@ -30,6 +39,28 @@ }; }; +&de { + status = "okay"; +}; + +&dphy { + status = "okay"; +}; + +&dsi { + vcc-dsi-supply = <®_dldo1>; + status = "okay"; + + panel@0 { + compatible = "techstar,ts8550b"; + reg = <0>; + avdd-supply = <®_dc1sw>; + dvdd-supply = <®_dldo2>; + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */ + backlight = <&backlight>; + }; +}; + &ehci0 { status = "okay"; }; @@ -72,6 +103,12 @@ status = "okay"; }; +&pwm { + pinctrl-names = "default"; + pinctrl-0 = <&pwm_pin>; + status = "okay"; +}; + &r_rsb { status = "okay"; @@ -107,6 +144,15 @@ regulator-name = "vcc-pll-avcc"; }; +®_dc1sw { + /* + * This regulator also indirectly drives the PD pingroup GPIOs, + * which also controls the power LED. + */ + regulator-always-on; + regulator-name = "vcc-phy"; +}; + ®_dcdc1 { regulator-always-on; regulator-min-microvolt = <3300000>;
Amarula A64-Relic board by default bound with Techstar TS8550B MIPI-DSI panel, add support for it. DSI panel connected via board DSI port with, - DC1SW as AVDD supply - DCDC2 as DVDD supply - DCDC1 as VCC-DSI supply - PD24 gpio for reset pin - PD23 gpio for backlight enable pin Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- .../allwinner/sun50i-a64-amarula-relic.dts | 46 +++++++++++++++++++ 1 file changed, 46 insertions(+)