clk: mmp: Off by one in mmp_clk_add()

Commit Message

Dan Carpenter Dec. 3, 2018, 2:51 p.m. UTC

The > comparison should be >= or we write one element beyond the end of
the unit->clk_table[] array.

(The unit->clk_table[] array is allocated in the mmp_clk_init() function
and it has unit->nr_clks elements).

Fixes: 4661fda10f8b ("clk: mmp: add basic support functions for DT support")
Signed-off-by: Dan Carpenter <[e-mail]>
---
 drivers/clk/mmp/clk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Boyd Dec. 3, 2018, 5:55 p.m. UTC | #1

Quoting Dan Carpenter (2018-12-03 06:51:43)
> The > comparison should be >= or we write one element beyond the end of
> the unit->clk_table[] array.
> 
> (The unit->clk_table[] array is allocated in the mmp_clk_init() function
> and it has unit->nr_clks elements).
> 
> Fixes: 4661fda10f8b ("clk: mmp: add basic support functions for DT support")
> Signed-off-by: Dan Carpenter <[e-mail]>
> ---

Applied to clk-fixes

Patch

diff --git a/drivers/clk/mmp/clk.c b/drivers/clk/mmp/clk.c
index ad8d483a35cd..ca7d37e2c7be 100644
--- a/drivers/clk/mmp/clk.c
+++ b/drivers/clk/mmp/clk.c
@@ -183,7 +183,7 @@  void mmp_clk_add(struct mmp_clk_unit *unit, unsigned int id,
 		pr_err("CLK %d has invalid pointer %p\n", id, clk);
 		return;
 	}
-	if (id > unit->nr_clks) {
+	if (id >= unit->nr_clks) {
 		pr_err("CLK %d is invalid\n", id);
 		return;
 	}