| Message ID | 20181206215858.3880-9-sboyd@kernel.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | Remove CLK_IS_BASIC usage from clk drivers | expand |
Quoting Stephen Boyd (2018-12-06 13:58:58) > This flag doesn't look to be used by any code, just set in the clk init > structure and then never tested again. Remove it from this driver as it > doesn't provide any benefit. Also remove parenthesis nearby that are not > needed and include clk.h to fix a sparse warning about static function > definition. > > Signed-off-by: Stephen Boyd <sboyd@kernel.org> > --- Applied to clk-next
diff --git a/drivers/clk/loongson1/clk.c b/drivers/clk/loongson1/clk.c index cfcfd143fccb..983ce9f6edbb 100644 --- a/drivers/clk/loongson1/clk.c +++ b/drivers/clk/loongson1/clk.c @@ -10,6 +10,8 @@ #include <linux/clk-provider.h> #include <linux/slab.h> +#include "clk.h" + struct clk_hw *__init clk_hw_register_pll(struct device *dev, const char *name, const char *parent_name, @@ -27,9 +29,9 @@ struct clk_hw *__init clk_hw_register_pll(struct device *dev, init.name = name; init.ops = ops; - init.flags = flags | CLK_IS_BASIC; - init.parent_names = (parent_name ? &parent_name : NULL); - init.num_parents = (parent_name ? 1 : 0); + init.flags = flags; + init.parent_names = parent_name ? &parent_name : NULL; + init.num_parents = parent_name ? 1 : 0; hw->init = &init; /* register the clock */
This flag doesn't look to be used by any code, just set in the clk init structure and then never tested again. Remove it from this driver as it doesn't provide any benefit. Also remove parenthesis nearby that are not needed and include clk.h to fix a sparse warning about static function definition. Signed-off-by: Stephen Boyd <sboyd@kernel.org> --- drivers/clk/loongson1/clk.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)