From patchwork Wed Dec 26 13:55:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 10743165 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9304E6C5 for ; Wed, 26 Dec 2018 13:55:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 723CD28448 for ; Wed, 26 Dec 2018 13:55:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6113F28737; Wed, 26 Dec 2018 13:55:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 10CF028448 for ; Wed, 26 Dec 2018 13:55:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726720AbeLZNzN (ORCPT ); Wed, 26 Dec 2018 08:55:13 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:37420 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726666AbeLZNzN (ORCPT ); Wed, 26 Dec 2018 08:55:13 -0500 Received: by mail-pg1-f195.google.com with SMTP id c25so7610087pgb.4; Wed, 26 Dec 2018 05:55:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=5Zz16nfT58+XQAHXbGtWdJkBNWf1Jd/OYxpOKCSmJMg=; b=LKYqIJKyNKfkqCzs9h46JLq0ftiFFtRumRQo+2D1tJfc/HVzFFtIew5mkZI6nohLZu hSUpBjW9h9NnUjSd5MRLq2hdWmaIFBmBXYyeZOsdyl9vDPD9v08sgGZQIzDrc29virs8 VlSHfZ/vGT77Sgb8wDs/z2JFAgGDUO7rVNEOm6is2A4lzrNfiBlytsjHahxSakWQ3Q/r j9VleG6o7u4pQcIqSaxBH/StrafRuMHslc2sDtY8uy+gqlJU8HJBu1FCPkPVelYl7iXO Dv7KCEsLVp+Al0QWpwjWjiUFHw71mstaYC1OToMf0LgO9QCMosFAokAoxS/Vw4fkkss4 U1RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5Zz16nfT58+XQAHXbGtWdJkBNWf1Jd/OYxpOKCSmJMg=; b=nAHJHwDA1ycy/41iiKLllrjR+P1MdeyFk9Al0IgORIVvqhFt/Xv9KudOBS538lCnjz VhpUqS0wu9l++WSSItA9aqplVmYSEq7h5fDe2sPxuWCP9JqcMDGhdTVqlZSzZ0rPZJwC +q4LGxxL3i95zNaJvP5fybvNdodmUmjD+JMrAFVKzeEoMfMKmREEeAkk1Rv0gUVfMRJZ 8moB+i/ZQ3j1xv90UOEnQ5IEZAy74J4RA2GdNt3j8WtMXe7IQJtMqQ0edxtOA8VLLp2I JPhdZu4XUPJ0sfWOM4yVuYgfuRbVIP5YnnOcVq8Dy9mUJtnjQm+TJfw6gQcRH1awcEhy RBnQ== X-Gm-Message-State: AJcUukfkcH4S6rtcA1w8hSqnzHpUxaAkxfWf3bprIAK9nQrBWdYeBqaV E0w4KscUjwyIGqjjsM6AVTQ= X-Google-Smtp-Source: ALg8bN5n8c6I0v108i9fF1qEo5zCn37vdEl0XaI2Jj7NXM4rmn0f2RpEsUJUIfgkQv/KPtu+QoCZBQ== X-Received: by 2002:a63:2263:: with SMTP id t35mr18970388pgm.69.1545832512792; Wed, 26 Dec 2018 05:55:12 -0800 (PST) Received: from localhost (68.168.130.77.16clouds.com. [68.168.130.77]) by smtp.gmail.com with ESMTPSA id 125sm70514701pfx.159.2018.12.26.05.55.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Dec 2018 05:55:12 -0800 (PST) From: Yangtao Li To: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, fabio.estevam@nxp.com, linux-imx@nxp.com, mturquette@baylibre.com, sboyd@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Yangtao Li Subject: [PATCH] clk: imx6sx: fix refcount leak in imx6sx_clocks_init() Date: Wed, 26 Dec 2018 08:55:10 -0500 Message-Id: <20181226135510.5862-1-tiny.windzz@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount. Signed-off-by: Yangtao Li --- drivers/clk/imx/clk-imx6sx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/imx/clk-imx6sx.c b/drivers/clk/imx/clk-imx6sx.c index 18527a335ace..91558b09bf9e 100644 --- a/drivers/clk/imx/clk-imx6sx.c +++ b/drivers/clk/imx/clk-imx6sx.c @@ -151,6 +151,7 @@ static void __init imx6sx_clocks_init(struct device_node *ccm_node) np = of_find_compatible_node(NULL, NULL, "fsl,imx6sx-anatop"); base = of_iomap(np, 0); WARN_ON(!base); + of_node_put(np); clks[IMX6SX_PLL1_BYPASS_SRC] = imx_clk_mux("pll1_bypass_src", base + 0x00, 14, 1, pll_bypass_src_sels, ARRAY_SIZE(pll_bypass_src_sels)); clks[IMX6SX_PLL2_BYPASS_SRC] = imx_clk_mux("pll2_bypass_src", base + 0x30, 14, 1, pll_bypass_src_sels, ARRAY_SIZE(pll_bypass_src_sels));