| Message ID | 20190212135154.2733-4-gabriel.fernandez@st.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | update STM32MP1 clocks | expand |
Quoting gabriel.fernandez@st.com (2019-02-12 05:51:50) > From: Gabriel Fernandez <gabriel.fernandez@st.com> > > ck_csi is used for IO compensation so it should be > considered as "always-on" and kept on. > > Signed-off-by: Gabriel Fernandez <gabriel.fernandez@st.com> > --- > drivers/clk/clk-stm32mp1.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/clk-stm32mp1.c b/drivers/clk/clk-stm32mp1.c > index e72079de83f4..5b30e4eeca2c 100644 > --- a/drivers/clk/clk-stm32mp1.c > +++ b/drivers/clk/clk-stm32mp1.c > @@ -1661,7 +1661,8 @@ static const struct clock_config stm32mp1_clock_cfg[] = { > > /* External / Internal Oscillators */ > GATE_MP1(CK_HSE, "ck_hse", "clk-hse", 0, RCC_OCENSETR, 8, 0), > - GATE_MP1(CK_CSI, "ck_csi", "clk-csi", 0, RCC_OCENSETR, 4, 0), > + GATE_MP1(CK_CSI, "ck_csi", "clk-csi", CLK_IS_CRITICAL, Please add a comment to the code indicating this so we know why critical is here without reading git history.
diff --git a/drivers/clk/clk-stm32mp1.c b/drivers/clk/clk-stm32mp1.c index e72079de83f4..5b30e4eeca2c 100644 --- a/drivers/clk/clk-stm32mp1.c +++ b/drivers/clk/clk-stm32mp1.c @@ -1661,7 +1661,8 @@ static const struct clock_config stm32mp1_clock_cfg[] = { /* External / Internal Oscillators */ GATE_MP1(CK_HSE, "ck_hse", "clk-hse", 0, RCC_OCENSETR, 8, 0), - GATE_MP1(CK_CSI, "ck_csi", "clk-csi", 0, RCC_OCENSETR, 4, 0), + GATE_MP1(CK_CSI, "ck_csi", "clk-csi", CLK_IS_CRITICAL, + RCC_OCENSETR, 4, 0), GATE_MP1(CK_HSI, "ck_hsi", "clk-hsi-div", 0, RCC_OCENSETR, 0, 0), GATE(CK_LSI, "ck_lsi", "clk-lsi", 0, RCC_RDLSICR, 0, 0), GATE(CK_LSE, "ck_lse", "clk-lse", 0, RCC_BDCR, 0, 0),