| Message ID | 20190404113722.20634-1-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [git,pull] clk: renesas: Updates for v5.2 | expand |
Quoting Geert Uytterhoeven (2019-04-04 04:37:22) > Hi Mike, Stephen, > > The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b: > > Linux 5.1-rc1 (2019-03-17 14:22:26 -0700) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git tags/clk-renesas-for-v5.2-tag1 > > for you to fetch changes up to b953eaaeb58efc944f51cffd3f6838657958f0f8: > > clk: renesas: rcar-gen3: Fix cpg_sd_clock_round_rate() return value (2019-04-04 11:54:46 +0200) > > ---------------------------------------------------------------- > clk: renesas: Updates for v5.2 > > - Add missing PCI USB clock on RZ/N1, > - Add Z2 (Cortex-A53) clocks on R-Car E3 and RZ/G2E, incl. a new > helper in <linux/math64.h>, > - Small fixes and cleanups. > Thanks. Pulled into clk-next with the below fix squashed on top. ----8<---- From: Stephen Boyd <sboyd@kernel.org> Subject: [PATCH] clk: renesas: rcar-gen3: Remove unused variable This variable is no longer used and the compiler rightly complains that it should be removed. Drop it to silence the following: drivers/clk/renesas/rcar-gen3-cpg.c: In function 'cpg_sd_clk_register': drivers/clk/renesas/rcar-gen3-cpg.c:386:15: warning: unused variable 'i' [-Wunused-variable] unsigned int i; Cc: Geert Uytterhoeven <geert+renesas@glider.be> Fixes: b953eaaeb58e ("clk: renesas: rcar-gen3: Fix cpg_sd_clock_round_rate() return value") Signed-off-by: Stephen Boyd <sboyd@kernel.org> --- drivers/clk/renesas/rcar-gen3-cpg.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clk/renesas/rcar-gen3-cpg.c b/drivers/clk/renesas/rcar-gen3-cpg.c index dc62ed0dadc2..d25c8ba00a65 100644 --- a/drivers/clk/renesas/rcar-gen3-cpg.c +++ b/drivers/clk/renesas/rcar-gen3-cpg.c @@ -383,7 +383,6 @@ static struct clk * __init cpg_sd_clk_register(const char *name, struct clk_init_data init; struct sd_clock *clock; struct clk *clk; - unsigned int i; u32 val; clock = kzalloc(sizeof(*clock), GFP_KERNEL);
Hi Stephen, On Thu, Apr 11, 2019 at 7:36 PM Stephen Boyd <sboyd@kernel.org> wrote: > Quoting Geert Uytterhoeven (2019-04-04 04:37:22) > > The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b: > > > > Linux 5.1-rc1 (2019-03-17 14:22:26 -0700) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git tags/clk-renesas-for-v5.2-tag1 > > > > for you to fetch changes up to b953eaaeb58efc944f51cffd3f6838657958f0f8: > > > > clk: renesas: rcar-gen3: Fix cpg_sd_clock_round_rate() return value (2019-04-04 11:54:46 +0200) > > > > ---------------------------------------------------------------- > > clk: renesas: Updates for v5.2 > > > > - Add missing PCI USB clock on RZ/N1, > > - Add Z2 (Cortex-A53) clocks on R-Car E3 and RZ/G2E, incl. a new > > helper in <linux/math64.h>, > > - Small fixes and cleanups. > > > > Thanks. Pulled into clk-next with the below fix squashed on top. > > ----8<---- > From: Stephen Boyd <sboyd@kernel.org> > Subject: [PATCH] clk: renesas: rcar-gen3: Remove unused variable > > This variable is no longer used and the compiler rightly complains that > it should be removed. Drop it to silence the following: > > drivers/clk/renesas/rcar-gen3-cpg.c: In function 'cpg_sd_clk_register': > drivers/clk/renesas/rcar-gen3-cpg.c:386:15: warning: unused variable 'i' [-Wunused-variable] > unsigned int i; > > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Fixes: b953eaaeb58e ("clk: renesas: rcar-gen3: Fix cpg_sd_clock_round_rate() return value") > Signed-off-by: Stephen Boyd <sboyd@kernel.org> Thanks pulling, and for fixing this silly oversight. /me wants his gcc-4.1 back... Gr{oetje,eeting}s, Geert
Quoting Geert Uytterhoeven (2019-04-23 00:46:50) > On Thu, Apr 11, 2019 at 7:36 PM Stephen Boyd <sboyd@kernel.org> wrote: > > Quoting Geert Uytterhoeven (2019-04-04 04:37:22) > > > > ----8<---- > > From: Stephen Boyd <sboyd@kernel.org> > > Subject: [PATCH] clk: renesas: rcar-gen3: Remove unused variable > > > > This variable is no longer used and the compiler rightly complains that > > it should be removed. Drop it to silence the following: > > > > drivers/clk/renesas/rcar-gen3-cpg.c: In function 'cpg_sd_clk_register': > > drivers/clk/renesas/rcar-gen3-cpg.c:386:15: warning: unused variable 'i' [-Wunused-variable] > > unsigned int i; > > > > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > > Fixes: b953eaaeb58e ("clk: renesas: rcar-gen3: Fix cpg_sd_clock_round_rate() return value") > > Signed-off-by: Stephen Boyd <sboyd@kernel.org> > > Thanks pulling, and for fixing this silly oversight. > > /me wants his gcc-4.1 back... Reminds me that I should roll llvm/clang into my testing flow. Is it working yet? Last time I tried it wasn't working.
Hi Mike, Stephen, The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b: Linux 5.1-rc1 (2019-03-17 14:22:26 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git tags/clk-renesas-for-v5.2-tag1 for you to fetch changes up to b953eaaeb58efc944f51cffd3f6838657958f0f8: clk: renesas: rcar-gen3: Fix cpg_sd_clock_round_rate() return value (2019-04-04 11:54:46 +0200) ---------------------------------------------------------------- clk: renesas: Updates for v5.2 - Add missing PCI USB clock on RZ/N1, - Add Z2 (Cortex-A53) clocks on R-Car E3 and RZ/G2E, incl. a new helper in <linux/math64.h>, - Small fixes and cleanups. Thanks for pulling! ---------------------------------------------------------------- Gareth Williams (1): clk: renesas: r9a06g032: Add missing PCI USB clock Geert Uytterhoeven (2): clk: renesas: rcar-gen3: Pass name/offset to cpg_sd_clk_register() clk: renesas: r7s9210: Always use readl() Kazuya Mizuguchi (2): clk: renesas: rcar-gen3: Correct parent clock of EHCI/OHCI clk: renesas: rcar-gen3: Correct parent clock of HS-USB Sergei Shtylyov (1): clk: renesas: r8a77980: Fix RPC-IF module clock's parent Simon Horman (5): clk: renesas: rcar-gen3: Parameterise Z and Z2 clock offset clk: renesas: rcar-gen3: Remove CLK_TYPE_GEN3_Z2 math64: New DIV64_U64_ROUND_CLOSEST helper clk: renesas: rcar-gen3: Support Z and Z2 clocks with high frequency parents clk: renesas: r8a774c0: Add Z2 clock Takeshi Kihara (6): clk: renesas: rcar-gen3: Parameterise Z and Z2 clock fixed divisor clk: renesas: r8a77990: Add Z2 clock clk: renesas: rcar-gen3: Correct parent clock of SYS-DMAC clk: renesas: rcar-gen3: Correct parent clock of Audio-DMAC clk: renesas: rcar-gen3: Rename DRIF clocks clk: renesas: rcar-gen3: Fix cpg_sd_clock_round_rate() return value drivers/clk/renesas/r7s9210-cpg-mssr.c | 3 +- drivers/clk/renesas/r8a774a1-cpg-mssr.c | 18 ++++----- drivers/clk/renesas/r8a774c0-cpg-mssr.c | 7 ++-- drivers/clk/renesas/r8a7795-cpg-mssr.c | 41 +++++++++---------- drivers/clk/renesas/r8a7796-cpg-mssr.c | 35 +++++++++-------- drivers/clk/renesas/r8a77965-cpg-mssr.c | 33 ++++++++-------- drivers/clk/renesas/r8a77980-cpg-mssr.c | 2 +- drivers/clk/renesas/r8a77990-cpg-mssr.c | 25 ++++++------ drivers/clk/renesas/r8a77995-cpg-mssr.c | 2 +- drivers/clk/renesas/r9a06g032-clocks.c | 1 + drivers/clk/renesas/rcar-gen3-cpg.c | 70 ++++++++++++++++----------------- drivers/clk/renesas/rcar-gen3-cpg.h | 5 ++- include/linux/math64.h | 13 ++++++ 13 files changed, 137 insertions(+), 118 deletions(-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds