| Message ID | 20190617100432.13037-3-chris.packham@alliedtelesis.co.nz (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add support for Marvell 98DX1135 | expand |
On Mon, Jun 17, 2019 at 10:04:30PM +1200, Chris Packham wrote: > Add compatible string for the core clock on the 98dx1135 switch with > integrated CPU. Hi Chris Should there be a list of provider IDs and clock names? Thanks Andrew
Hi Andrew, On 18/06/19 5:09 AM, Andrew Lunn wrote: > On Mon, Jun 17, 2019 at 10:04:30PM +1200, Chris Packham wrote: >> Add compatible string for the core clock on the 98dx1135 switch with >> integrated CPU. > > Hi Chris > > Should there be a list of provider IDs and clock names? > That list would be the same as the Kirkwood/Dove. I thought about adding it but decided not to to avoid unnecessary duplication. One compromise would be to change "for 98dx1135 SoC core clocks" to "for Kirkwood 98dx1135 SoC" which would fit with the MV88f6180 line above and make it clear that it falls into the kirkwood bucket.
> That list would be the same as the Kirkwood/Dove. I thought about adding > it but decided not to to avoid unnecessary duplication. One compromise > would be to change "for 98dx1135 SoC core clocks" to "for Kirkwood > 98dx1135 SoC" which would fit with the MV88f6180 line above and make it > clear that it falls into the kirkwood bucket. Hi Chris The Compromise sounds good. Thanks Andrew
diff --git a/Documentation/devicetree/bindings/clock/mvebu-core-clock.txt b/Documentation/devicetree/bindings/clock/mvebu-core-clock.txt index 796c260c183d..76f0952cfc64 100644 --- a/Documentation/devicetree/bindings/clock/mvebu-core-clock.txt +++ b/Documentation/devicetree/bindings/clock/mvebu-core-clock.txt @@ -59,6 +59,7 @@ Required properties: "marvell,dove-core-clock" - for Dove SoC core clocks "marvell,kirkwood-core-clock" - for Kirkwood SoC (except mv88f6180) "marvell,mv88f6180-core-clock" - for Kirkwood MV88f6180 SoC + "marvell,mv98dx1135-core-clock" - for 98dx1135 SoC core clocks "marvell,mv88f5181-core-clock" - for Orion MV88F5181 SoC "marvell,mv88f5182-core-clock" - for Orion MV88F5182 SoC "marvell,mv88f5281-core-clock" - for Orion MV88F5281 SoC
Add compatible string for the core clock on the 98dx1135 switch with integrated CPU. Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> --- Documentation/devicetree/bindings/clock/mvebu-core-clock.txt | 1 + 1 file changed, 1 insertion(+)