diff mbox series

[-next] clk: tegra: Fix build error without CONFIG_PM_SLEEP

Message ID 20191030125650.36776-1-yuehaibing@huawei.com (mailing list archive)
State Awaiting Upstream, archived
Headers show
Series [-next] clk: tegra: Fix build error without CONFIG_PM_SLEEP | expand

Commit Message

Yue Haibing Oct. 30, 2019, 12:56 p.m. UTC
If CONFIG_PM_SLEEP is n, build fails:

drivers/clk/tegra/clk-tegra210.c:3426:13: error:
 tegra210_clk_suspend undeclared here (not in a function); did you mean tegra_clk_ndspeed?
  .suspend = tegra210_clk_suspend,
             ^~~~~~~~~~~~~~~~~~~~
             tegra_clk_ndspeed
drivers/clk/tegra/clk-tegra210.c:3427:12: error:
 tegra210_clk_resume undeclared here (not in a function); did you mean tegra210_clk_suspend?
  .resume = tegra210_clk_resume,

Use ifdef to guard this.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 27d10d548c04 ("clk: tegra: Add suspend and resume support on Tegra210")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/clk/tegra/clk-tegra210.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thierry Reding Nov. 1, 2019, 9:50 a.m. UTC | #1
On Wed, Oct 30, 2019 at 08:56:50PM +0800, YueHaibing wrote:
> If CONFIG_PM_SLEEP is n, build fails:
> 
> drivers/clk/tegra/clk-tegra210.c:3426:13: error:
>  tegra210_clk_suspend undeclared here (not in a function); did you mean tegra_clk_ndspeed?
>   .suspend = tegra210_clk_suspend,
>              ^~~~~~~~~~~~~~~~~~~~
>              tegra_clk_ndspeed
> drivers/clk/tegra/clk-tegra210.c:3427:12: error:
>  tegra210_clk_resume undeclared here (not in a function); did you mean tegra210_clk_suspend?
>   .resume = tegra210_clk_resume,
> 
> Use ifdef to guard this.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 27d10d548c04 ("clk: tegra: Add suspend and resume support on Tegra210")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/clk/tegra/clk-tegra210.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied to for-5.5/clk, thanks.

Thierry
diff mbox series

Patch

diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c
index d038fed..762cd18 100644
--- a/drivers/clk/tegra/clk-tegra210.c
+++ b/drivers/clk/tegra/clk-tegra210.c
@@ -3423,8 +3423,10 @@  static void tegra210_cpu_clock_resume(void)
 #endif
 
 static struct syscore_ops tegra_clk_syscore_ops = {
+#ifdef CONFIG_PM_SLEEP
 	.suspend = tegra210_clk_suspend,
 	.resume = tegra210_clk_resume,
+#endif
 };
 
 static struct tegra_cpu_car_ops tegra210_cpu_car_ops = {