| Message ID | 20191217044635.127912-1-olof@lixom.net (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v3] clk: declare clk_core_reparent_orphans() inline | expand |
Quoting Olof Johansson (2019-12-16 20:46:35) > A recent addition exposed a helper that is only used for > CONFIG_OF. Instead of figuring out best place to have it in the order > of various functions, just declare it as explicitly inline, and the > compiler will happily handle it without warning. > > (Also fixup of a single stray empty line while I was looking at the code) > > Fixes: 66d9506440bb ("clk: walk orphan list on clock provider registration") > Signed-off-by: Olof Johansson <olof@lixom.net> > --- > > v3: ACTUALLY amend this time. Sigh. Time to go home. > Isn't it simple enough to just move the function down to CONFIG_OF in drivers/clk/clk.c? ----8<---- diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index ae2795b30e06..6a11239ccde3 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -3277,13 +3277,6 @@ static void clk_core_reparent_orphans_nolock(void) } } -static void clk_core_reparent_orphans(void) -{ - clk_prepare_lock(); - clk_core_reparent_orphans_nolock(); - clk_prepare_unlock(); -} - /** * __clk_core_init - initialize the data structures in a struct clk_core * @core: clk_core being initialized @@ -4193,6 +4186,13 @@ int clk_notifier_unregister(struct clk *clk, struct notifier_block *nb) EXPORT_SYMBOL_GPL(clk_notifier_unregister); #ifdef CONFIG_OF +static void clk_core_reparent_orphans(void) +{ + clk_prepare_lock(); + clk_core_reparent_orphans_nolock(); + clk_prepare_unlock(); +} + /** * struct of_clk_provider - Clock provider registration structure * @link: Entry in global list of clock providers
On Tue, Dec 17, 2019 at 12:25 AM Stephen Boyd <sboyd@kernel.org> wrote: > > Quoting Olof Johansson (2019-12-16 20:46:35) > > A recent addition exposed a helper that is only used for > > CONFIG_OF. Instead of figuring out best place to have it in the order > > of various functions, just declare it as explicitly inline, and the > > compiler will happily handle it without warning. > > > > (Also fixup of a single stray empty line while I was looking at the code) > > > > Fixes: 66d9506440bb ("clk: walk orphan list on clock provider registration") > > Signed-off-by: Olof Johansson <olof@lixom.net> > > --- > > > > v3: ACTUALLY amend this time. Sigh. Time to go home. > > > > Isn't it simple enough to just move the function down to CONFIG_OF in > drivers/clk/clk.c? "Simple" in a 5000 line file is maybe not the right word to use, but yeah, sure, do with it what you want. Seems like clk.c could do with some refactoring? :) -Olof
Quoting Olof Johansson (2019-12-17 10:01:15) > On Tue, Dec 17, 2019 at 12:25 AM Stephen Boyd <sboyd@kernel.org> wrote: > > > > Quoting Olof Johansson (2019-12-16 20:46:35) > > > A recent addition exposed a helper that is only used for > > > CONFIG_OF. Instead of figuring out best place to have it in the order > > > of various functions, just declare it as explicitly inline, and the > > > compiler will happily handle it without warning. > > > > > > (Also fixup of a single stray empty line while I was looking at the code) > > > > > > Fixes: 66d9506440bb ("clk: walk orphan list on clock provider registration") > > > Signed-off-by: Olof Johansson <olof@lixom.net> > > > --- > > > > > > v3: ACTUALLY amend this time. Sigh. Time to go home. > > > > > > > Isn't it simple enough to just move the function down to CONFIG_OF in > > drivers/clk/clk.c? > > "Simple" in a 5000 line file is maybe not the right word to use, but > yeah, sure, do with it what you want. > > Seems like clk.c could do with some refactoring? :) > Ok.
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index ae2795b30e060..2b0f54b6af9d5 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -3277,7 +3277,7 @@ static void clk_core_reparent_orphans_nolock(void) } } -static void clk_core_reparent_orphans(void) +static void inline clk_core_reparent_orphans(void) { clk_prepare_lock(); clk_core_reparent_orphans_nolock(); @@ -3442,7 +3442,6 @@ static int __clk_core_init(struct clk_core *core) clk_core_reparent_orphans_nolock(); - kref_init(&core->ref); out: clk_pm_runtime_put(core);
A recent addition exposed a helper that is only used for CONFIG_OF. Instead of figuring out best place to have it in the order of various functions, just declare it as explicitly inline, and the compiler will happily handle it without warning. (Also fixup of a single stray empty line while I was looking at the code) Fixes: 66d9506440bb ("clk: walk orphan list on clock provider registration") Signed-off-by: Olof Johansson <olof@lixom.net> --- v3: ACTUALLY amend this time. Sigh. Time to go home. drivers/clk/clk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)