| Message ID | 20200419170810.5738-8-robh@kernel.org (mailing list archive) |
|---|---|
| State | Awaiting Upstream, archived |
| Headers | show |
| Series | Modularizing Versatile Express | expand |
On Sun, Apr 19, 2020 at 7:08 PM Rob Herring <robh@kernel.org> wrote: > > In preparation to enable the vexpress-osc clock driver as a module, > convert the driver to use the managed devres clock API variants. With > this, a driver .remove() hook is not needed. > > Cc: Liviu Dudau <liviu.dudau@arm.com> > Cc: Sudeep Holla <sudeep.holla@arm.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: linux-clk@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> Acked-by: Arnd Bergmann <arnd@arndb.de>
Quoting Rob Herring (2020-04-19 10:08:00) > In preparation to enable the vexpress-osc clock driver as a module, > convert the driver to use the managed devres clock API variants. With > this, a driver .remove() hook is not needed. > > Cc: Liviu Dudau <liviu.dudau@arm.com> > Cc: Sudeep Holla <sudeep.holla@arm.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: linux-clk@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- Reviewed-by: Stephen Boyd <sboyd@kernel.org>
On Sun, Apr 19, 2020 at 12:08:00PM -0500, Rob Herring wrote: > In preparation to enable the vexpress-osc clock driver as a module, > convert the driver to use the managed devres clock API variants. With > this, a driver .remove() hook is not needed. > > Cc: Liviu Dudau <liviu.dudau@arm.com> Acked-by: Liviu Dudau <liviu.dudau@arm.com> > Cc: Sudeep Holla <sudeep.holla@arm.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: linux-clk@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/clk/versatile/clk-vexpress-osc.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c > index 7ade146a3ea9..5bb1d5a714d0 100644 > --- a/drivers/clk/versatile/clk-vexpress-osc.c > +++ b/drivers/clk/versatile/clk-vexpress-osc.c > @@ -65,8 +65,8 @@ static int vexpress_osc_probe(struct platform_device *pdev) > { > struct clk_init_data init; > struct vexpress_osc *osc; > - struct clk *clk; > u32 range[2]; > + int ret; > > osc = devm_kzalloc(&pdev->dev, sizeof(*osc), GFP_KERNEL); > if (!osc) > @@ -92,11 +92,11 @@ static int vexpress_osc_probe(struct platform_device *pdev) > > osc->hw.init = &init; > > - clk = clk_register(NULL, &osc->hw); > - if (IS_ERR(clk)) > - return PTR_ERR(clk); > + ret = devm_clk_hw_register(&pdev->dev, &osc->hw); > + if (ret < 0) > + return ret; > > - of_clk_add_provider(pdev->dev.of_node, of_clk_src_simple_get, clk); > + devm_of_clk_add_hw_provider(&pdev->dev, of_clk_hw_simple_get, &osc->hw); > clk_hw_set_rate_range(&osc->hw, osc->rate_min, osc->rate_max); > > dev_dbg(&pdev->dev, "Registered clock '%s'\n", init.name); > -- > 2.20.1 >
On Sun, Apr 19, 2020 at 12:08:00PM -0500, Rob Herring wrote: > In preparation to enable the vexpress-osc clock driver as a module, > convert the driver to use the managed devres clock API variants. With > this, a driver .remove() hook is not needed. > > Cc: Liviu Dudau <liviu.dudau@arm.com> > Cc: Sudeep Holla <sudeep.holla@arm.com> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com> -- Regards, Sudeep
diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c index 7ade146a3ea9..5bb1d5a714d0 100644 --- a/drivers/clk/versatile/clk-vexpress-osc.c +++ b/drivers/clk/versatile/clk-vexpress-osc.c @@ -65,8 +65,8 @@ static int vexpress_osc_probe(struct platform_device *pdev) { struct clk_init_data init; struct vexpress_osc *osc; - struct clk *clk; u32 range[2]; + int ret; osc = devm_kzalloc(&pdev->dev, sizeof(*osc), GFP_KERNEL); if (!osc) @@ -92,11 +92,11 @@ static int vexpress_osc_probe(struct platform_device *pdev) osc->hw.init = &init; - clk = clk_register(NULL, &osc->hw); - if (IS_ERR(clk)) - return PTR_ERR(clk); + ret = devm_clk_hw_register(&pdev->dev, &osc->hw); + if (ret < 0) + return ret; - of_clk_add_provider(pdev->dev.of_node, of_clk_src_simple_get, clk); + devm_of_clk_add_hw_provider(&pdev->dev, of_clk_hw_simple_get, &osc->hw); clk_hw_set_rate_range(&osc->hw, osc->rate_min, osc->rate_max); dev_dbg(&pdev->dev, "Registered clock '%s'\n", init.name);
In preparation to enable the vexpress-osc clock driver as a module, convert the driver to use the managed devres clock API variants. With this, a driver .remove() hook is not needed. Cc: Liviu Dudau <liviu.dudau@arm.com> Cc: Sudeep Holla <sudeep.holla@arm.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Stephen Boyd <sboyd@kernel.org> Cc: linux-clk@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/clk/versatile/clk-vexpress-osc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)