| Message ID | 20200424152301.4018-1-t-kristo@ti.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | clk: ti: am33xx: fix RTC clock parent | expand |
* Tero Kristo <t-kristo@ti.com> [200424 15:23]: > Right now, trying to use RTC purely with the ti-sysc / clkctrl framework > fails to enable the RTC module properly. Based on experimentation, this > appears to be because RTC is sourced from the clkdiv32k optional clock. > TRM is not very clear on this topic, but fix the RTC to use the proper > source clock nevertheless. > > Reported-by: Tony Lindgren <tony@atomide.com> > Signed-off-by: Tero Kristo <t-kristo@ti.com> This fixes the issue where RTC won't get enabled unless the clock is enabled by the bootloader or early init code: Acked-by: Tony Lindgren <tony@atomide.com>
Quoting Tero Kristo (2020-04-24 08:23:01) > Right now, trying to use RTC purely with the ti-sysc / clkctrl framework > fails to enable the RTC module properly. Based on experimentation, this > appears to be because RTC is sourced from the clkdiv32k optional clock. > TRM is not very clear on this topic, but fix the RTC to use the proper > source clock nevertheless. > > Reported-by: Tony Lindgren <tony@atomide.com> > Signed-off-by: Tero Kristo <t-kristo@ti.com> > --- Applied to clk-fixes
diff --git a/drivers/clk/ti/clk-33xx.c b/drivers/clk/ti/clk-33xx.c index e001b9bcb6bf..7dc30dd6c8d5 100644 --- a/drivers/clk/ti/clk-33xx.c +++ b/drivers/clk/ti/clk-33xx.c @@ -212,7 +212,7 @@ static const struct omap_clkctrl_reg_data am3_mpu_clkctrl_regs[] __initconst = { }; static const struct omap_clkctrl_reg_data am3_l4_rtc_clkctrl_regs[] __initconst = { - { AM3_L4_RTC_RTC_CLKCTRL, NULL, CLKF_SW_SUP, "clk_32768_ck" }, + { AM3_L4_RTC_RTC_CLKCTRL, NULL, CLKF_SW_SUP, "clk-24mhz-clkctrl:0000:0" }, { 0 }, };
Right now, trying to use RTC purely with the ti-sysc / clkctrl framework fails to enable the RTC module properly. Based on experimentation, this appears to be because RTC is sourced from the clkdiv32k optional clock. TRM is not very clear on this topic, but fix the RTC to use the proper source clock nevertheless. Reported-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Tero Kristo <t-kristo@ti.com> --- drivers/clk/ti/clk-33xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)