| Message ID | 20200506120304.31550-1-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Awaiting Upstream, archived |
| Headers | show |
| Series | media: i2c: imx219: Drop <linux/clk-provider.h> and <linux/clkdev.h> | expand |
Quoting Geert Uytterhoeven (2020-05-06 05:03:04) > The IMX219 camera driver is not a clock provider, but merely a clock > consumer, and thus does not need to include <linux/clk-provider.h> and > <linux/clkdev.h>. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- Reviewed-by: Stephen Boyd <sboyd@kernel.org>
On Wed, 6 May 2020 at 13:03, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > The IMX219 camera driver is not a clock provider, but merely a clock > consumer, and thus does not need to include <linux/clk-provider.h> and > <linux/clkdev.h>. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> I'm no expert on the clock frameworks, but that seems logical. Acked-by: Dave Stevenson <dave.stevenson@raspberrypi.com> The same appears to be true for drivers/media/i2c/ov5640.c unless it's been fixed since 5.7-rc5. > --- > drivers/media/i2c/imx219.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c > index cb03bdec1f9c8954..078f2093d881d7c2 100644 > --- a/drivers/media/i2c/imx219.c > +++ b/drivers/media/i2c/imx219.c > @@ -15,8 +15,6 @@ > */ > > #include <linux/clk.h> > -#include <linux/clk-provider.h> > -#include <linux/clkdev.h> > #include <linux/delay.h> > #include <linux/gpio/consumer.h> > #include <linux/i2c.h> > -- > 2.17.1 >
Hi Dave On Thu, May 14, 2020 at 3:12 PM Dave Stevenson <dave.stevenson@raspberrypi.com> wrote: > On Wed, 6 May 2020 at 13:03, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > The IMX219 camera driver is not a clock provider, but merely a clock > > consumer, and thus does not need to include <linux/clk-provider.h> and > > <linux/clkdev.h>. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > I'm no expert on the clock frameworks, but that seems logical. > Acked-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Thank you. > The same appears to be true for drivers/media/i2c/ov5640.c unless it's > been fixed since 5.7-rc5. Quite possible: I did a sweep a while ago, and looked at recently introduced offenders, but I may have missed some. Gr{oetje,eeting}s, Geert
diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index cb03bdec1f9c8954..078f2093d881d7c2 100644 --- a/drivers/media/i2c/imx219.c +++ b/drivers/media/i2c/imx219.c @@ -15,8 +15,6 @@ */ #include <linux/clk.h> -#include <linux/clk-provider.h> -#include <linux/clkdev.h> #include <linux/delay.h> #include <linux/gpio/consumer.h> #include <linux/i2c.h>
The IMX219 camera driver is not a clock provider, but merely a clock consumer, and thus does not need to include <linux/clk-provider.h> and <linux/clkdev.h>. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/media/i2c/imx219.c | 2 -- 1 file changed, 2 deletions(-)