diff mbox series

[v6,6/7] clk: tegra: Don't allow zero clock rate for PLLs

Message ID 20210320152648.8389-7-digetx@gmail.com (mailing list archive)
State Under Review
Headers show
Series Couple improvements for Tegra clk driver | expand

Commit Message

Dmitry Osipenko March 20, 2021, 3:26 p.m. UTC
Zero clock rate doesn't make sense for PLLs and tegra-clk driver enters
into infinite loop on trying to calculate PLL parameters for zero rate.
Make code to error out if requested rate is zero.

Originally this trouble was found by Robert Yang while he was trying to
bring up upstream kernel on Samsung Galaxy Tab, which happened due to a
bug in Tegra DRM driver that erroneously sets PLL rate to zero. This
issues came over again recently during of kernel bring up on ASUS TF700T.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
 drivers/clk/tegra/clk-pll.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series


diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
index d709ecb7d8d7..af7d4941042e 100644
--- a/drivers/clk/tegra/clk-pll.c
+++ b/drivers/clk/tegra/clk-pll.c
@@ -558,6 +558,9 @@  static int _calc_rate(struct clk_hw *hw, struct tegra_clk_pll_freq_table *cfg,
 	u32 p_div = 0;
 	int ret;
+	if (!rate)
+		return -EINVAL;
 	switch (parent_rate) {
 	case 12000000:
 	case 26000000: