| Message ID | 20210721151136.2060107-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | clk: hisilicon: hi3559A: select CONFIG_RESET_HISI | expand |
On 7/21/21 8:11 AM, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The reset functions are in a library that has to be selected > for each driver using them: > > aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi3559av100_crg_remove': > clk-hi3559a.c:(.text+0x1c8): undefined reference to `hisi_reset_exit' > clk-hi3559a.c:(.text+0x1c8): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `hisi_reset_exit' > aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi3559av100_crg_probe': > clk-hi3559a.c:(.text+0x284): undefined reference to `hisi_reset_init' > clk-hi3559a.c:(.text+0x284): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `hisi_reset_init' > aarch64-linux-ld: clk-hi3559a.c:(.text+0x2e8): undefined reference to `hisi_reset_exit' > clk-hi3559a.c:(.text+0x2e8): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `hisi_reset_exit' > > Add the select to 3559 as well. > > Fixes: 6c81966107dc ("clk: hisilicon: Add clock driver for hi3559A SoC") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/clk/hisilicon/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/hisilicon/Kconfig b/drivers/clk/hisilicon/Kconfig > index 5ecc37aaa118..c1ec75aa4ccd 100644 > --- a/drivers/clk/hisilicon/Kconfig > +++ b/drivers/clk/hisilicon/Kconfig > @@ -18,6 +18,7 @@ config COMMON_CLK_HI3519 > config COMMON_CLK_HI3559A > bool "Hi3559A Clock Driver" > depends on ARCH_HISI || COMPILE_TEST > + select RESET_HISI > default ARCH_HISI > help > Build the clock driver for hi3559a. > https://lore.kernel.org/lkml/20210717043159.12566-1-rdunlap@infradead.org/
diff --git a/drivers/clk/hisilicon/Kconfig b/drivers/clk/hisilicon/Kconfig index 5ecc37aaa118..c1ec75aa4ccd 100644 --- a/drivers/clk/hisilicon/Kconfig +++ b/drivers/clk/hisilicon/Kconfig @@ -18,6 +18,7 @@ config COMMON_CLK_HI3519 config COMMON_CLK_HI3559A bool "Hi3559A Clock Driver" depends on ARCH_HISI || COMPILE_TEST + select RESET_HISI default ARCH_HISI help Build the clock driver for hi3559a.