| Message ID | 20210901180953.5bd2a994@endymion (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [1/2] clk: versatile: Rename ICST to CLK_ICST | expand |
On Wed, Sep 1, 2021 at 6:09 PM Jean Delvare <jdelvare@suse.de> wrote: > Commit 419b3ab6987f ("clk: versatile: remove dependency on ARCH_*") > made the whole menu of ARM reference clock drivers visible on all > architectures. I can't see how this is an improvement for non-ARM > users. Unless build-testing, there is no point on presenting > ARM-only clock drivers on other architectures. > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > Cc: Peter Collingbourne <pcc@google.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Stephen Boyd <sboyd@kernel.org> OK then: Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
Quoting Jean Delvare (2021-09-01 09:09:53) > Commit 419b3ab6987f ("clk: versatile: remove dependency on ARCH_*") > made the whole menu of ARM reference clock drivers visible on all > architectures. I can't see how this is an improvement for non-ARM > users. Unless build-testing, there is no point on presenting > ARM-only clock drivers on other architectures. > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > Cc: Peter Collingbourne <pcc@google.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Stephen Boyd <sboyd@kernel.org> > --- Applied to clk-next
--- linux-5.14.orig/drivers/clk/versatile/Kconfig 2021-09-01 17:28:15.853037684 +0200 +++ linux-5.14/drivers/clk/versatile/Kconfig 2021-09-01 17:32:58.498817653 +0200 @@ -2,6 +2,7 @@ menu "Clock driver for ARM Reference designs" depends on HAS_IOMEM + depends on ARM || ARM64 || COMPILE_TEST config CLK_ICST bool "Clock driver for ARM Reference designs ICST"
Commit 419b3ab6987f ("clk: versatile: remove dependency on ARCH_*") made the whole menu of ARM reference clock drivers visible on all architectures. I can't see how this is an improvement for non-ARM users. Unless build-testing, there is no point on presenting ARM-only clock drivers on other architectures. Signed-off-by: Jean Delvare <jdelvare@suse.de> Cc: Peter Collingbourne <pcc@google.com> Cc: Lee Jones <lee.jones@linaro.org> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Stephen Boyd <sboyd@kernel.org> --- drivers/clk/versatile/Kconfig | 1 + 1 file changed, 1 insertion(+)