diff mbox series

[v2] clk: imx: use module_platform_driver

Message ID 20210904152946.32042-1-miles.chen@mediatek.com (mailing list archive)
State Changes Requested, archived
Headers show
Series [v2] clk: imx: use module_platform_driver | expand

Commit Message

Miles Chen Sept. 4, 2021, 3:29 p.m. UTC 
Replace builtin_platform_driver_probe with module_platform_driver_probe
because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).

Fixes: c2cccb6d0b33 ("clk: imx: add imx8qxp clk driver")
Fixes: 1e3121bfe51a ("clk: imx: add imx8qxp lpcg driver")
Cc: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Miles Chen <miles.chen@mediatek.com>

---

Change since v1:
Add Fixes tags

---
 drivers/clk/imx/clk-imx8qxp-lpcg.c | 2 +-
 drivers/clk/imx/clk-imx8qxp.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Fabio Estevam Sept. 4, 2021, 4:43 p.m. UTC | #1 
Hi Miles,

On Sat, Sep 4, 2021 at 12:29 PM Miles Chen <miles.chen@mediatek.com> wrote:
>
> Replace builtin_platform_driver_probe with module_platform_driver_probe
> because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).
>
> Fixes: c2cccb6d0b33 ("clk: imx: add imx8qxp clk driver")
> Fixes: 1e3121bfe51a ("clk: imx: add imx8qxp lpcg driver")

The correct Fixes tag would be:

Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock
driver as module")

Thanks
Miles Chen Sept. 4, 2021, 11:52 p.m. UTC | #2 
On Sat, 2021-09-04 at 13:43 -0300, Fabio Estevam wrote:
> Hi Miles,
> 
> On Sat, Sep 4, 2021 at 12:29 PM Miles Chen <miles.chen@mediatek.com>
> wrote:
> > 
> > Replace builtin_platform_driver_probe with
> > module_platform_driver_probe
> > because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).
> > 
> > Fixes: c2cccb6d0b33 ("clk: imx: add imx8qxp clk driver")
> > Fixes: 1e3121bfe51a ("clk: imx: add imx8qxp lpcg driver")
> 
> The correct Fixes tag would be:
> 
> Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock
> driver as module")
> 

Thanks, I will fix the tag in next patch.

Miles
> Thanks
diff mbox series

Patch

diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c
index d3e905cf867d..b23758083ce5 100644
--- a/drivers/clk/imx/clk-imx8qxp-lpcg.c
+++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c
@@ -370,7 +370,7 @@  static struct platform_driver imx8qxp_lpcg_clk_driver = {
 	.probe = imx8qxp_lpcg_clk_probe,
 };
 
-builtin_platform_driver(imx8qxp_lpcg_clk_driver);
+module_platform_driver(imx8qxp_lpcg_clk_driver);
 
 MODULE_AUTHOR("Aisheng Dong <aisheng.dong@nxp.com>");
 MODULE_DESCRIPTION("NXP i.MX8QXP LPCG clock driver");
diff --git a/drivers/clk/imx/clk-imx8qxp.c b/drivers/clk/imx/clk-imx8qxp.c
index c53a688d8ccc..40a2efb1329b 100644
--- a/drivers/clk/imx/clk-imx8qxp.c
+++ b/drivers/clk/imx/clk-imx8qxp.c
@@ -308,7 +308,7 @@  static struct platform_driver imx8qxp_clk_driver = {
 	},
 	.probe = imx8qxp_clk_probe,
 };
-builtin_platform_driver(imx8qxp_clk_driver);
+module_platform_driver(imx8qxp_clk_driver);
 
 MODULE_AUTHOR("Aisheng Dong <aisheng.dong@nxp.com>");
 MODULE_DESCRIPTION("NXP i.MX8QXP clock driver");