Message ID | 20211126221239.1100960-1-colin.i.king@gmail.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers | show |
Series | clk: stm32mp1: remove redundant assignment to pointer data | expand |
Quoting Colin Ian King (2021-11-26 14:12:39) > The pointer data is being initialized with a value and a few lines > later on being re-assigned the same value, so this re-assignment is > redundant. Clean up the code and remove it. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- Applied to clk-next
diff --git a/drivers/clk/clk-stm32mp1.c b/drivers/clk/clk-stm32mp1.c index 4bd1fe7d8af4..863274aa50e3 100644 --- a/drivers/clk/clk-stm32mp1.c +++ b/drivers/clk/clk-stm32mp1.c @@ -2253,8 +2253,6 @@ static int stm32_rcc_reset_init(struct device *dev, void __iomem *base, const struct stm32_rcc_match_data *data = match->data; struct stm32_reset_data *reset_data = NULL; - data = match->data; - reset_data = kzalloc(sizeof(*reset_data), GFP_KERNEL); if (!reset_data) return -ENOMEM;
The pointer data is being initialized with a value and a few lines later on being re-assigned the same value, so this re-assignment is redundant. Clean up the code and remove it. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/clk/clk-stm32mp1.c | 2 -- 1 file changed, 2 deletions(-)