diff mbox series

[RESEND,v4,8/9] clk: cs2000-cp: freeze config during register fiddling

Message ID 20220125093336.226787-9-daniel@zonque.org (mailing list archive)
State Accepted, archived
Headers show
Series clk: cs2000-cp: add dynamic mode and more features | expand

Commit Message

Daniel Mack Jan. 25, 2022, 9:33 a.m. UTC 
Make sure to freeze the configuration of the chip during the programming
of 32-bit registers. This avoids the processing of invalid intermediate
states.

Signed-off-by: Daniel Mack <daniel@zonque.org>
---
 drivers/clk/clk-cs2000-cp.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Stephen Boyd Jan. 25, 2022, 10:30 p.m. UTC | #1 
Quoting Daniel Mack (2022-01-25 01:33:35)
> Make sure to freeze the configuration of the chip during the programming
> of 32-bit registers. This avoids the processing of invalid intermediate
> states.
> 
> Signed-off-by: Daniel Mack <daniel@zonque.org>
> ---

Applied to clk-next
diff mbox series

Patch

diff --git a/drivers/clk/clk-cs2000-cp.c b/drivers/clk/clk-cs2000-cp.c
index 9f99e39b41f2..1baf0595ba59 100644
--- a/drivers/clk/clk-cs2000-cp.c
+++ b/drivers/clk/clk-cs2000-cp.c
@@ -52,6 +52,7 @@ 
 #define FRACNSRC_DYNAMIC	(1 << 0)
 
 /* GLOBAL_CFG */
+#define FREEZE		(1 << 7)
 #define ENDEV2		(0x1)
 
 /* FUNC_CFG1 */
@@ -335,6 +336,10 @@  static int __cs2000_set_rate(struct cs2000_priv *priv, int ch,
 {
 	int ret;
 
+	ret = cs2000_bset(priv, GLOBAL_CFG, FREEZE, FREEZE);
+	if (ret < 0)
+		return ret;
+
 	ret = cs2000_select_ratio_mode(priv, rate, parent_rate);
 	if (ret < 0)
 		return ret;
@@ -347,6 +352,10 @@  static int __cs2000_set_rate(struct cs2000_priv *priv, int ch,
 	if (ret < 0)
 		return ret;
 
+	ret = cs2000_bset(priv, GLOBAL_CFG, FREEZE, 0);
+	if (ret < 0)
+		return ret;
+
 	priv->saved_rate	= rate;
 	priv->saved_parent_rate	= parent_rate;