| Message ID | 20220208124034.414635-9-wenst@chromium.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | clk: mediatek: Cleanups and Improvements - Part 1 | expand |
On Tue, 2022-02-08 at 20:40 +0800, Chen-Yu Tsai wrote: > Some headers with the declaration of functions and structures aren't > directly included. Explicitly include them so that future changes to > other headers would not result in an unexpected build break. > > On the header side, add forward declarations for any data structures > whose pointers are used in function signatures. No headers are > required. > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > Reviewed-by: Miles Chen <miles.chen@mediatek.com> > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> Reviewed-by: Chun-Jie Chen <chun-jie.chen@mediatek.com> > --- > drivers/clk/mediatek/clk-cpumux.c | 3 +++ > drivers/clk/mediatek/clk-cpumux.h | 4 ++++ > 2 files changed, 7 insertions(+) > > diff --git a/drivers/clk/mediatek/clk-cpumux.c > b/drivers/clk/mediatek/clk-cpumux.c > index 344c6399b22f..658aee789f44 100644 > --- a/drivers/clk/mediatek/clk-cpumux.c > +++ b/drivers/clk/mediatek/clk-cpumux.c > @@ -5,8 +5,11 @@ > */ > > #include <linux/clk-provider.h> > +#include <linux/container_of.h> > +#include <linux/err.h> > #include <linux/mfd/syscon.h> > #include <linux/module.h> > +#include <linux/regmap.h> > #include <linux/slab.h> > > #include "clk-mtk.h" > diff --git a/drivers/clk/mediatek/clk-cpumux.h > b/drivers/clk/mediatek/clk-cpumux.h > index a538f2bbef0d..b07e89f7c283 100644 > --- a/drivers/clk/mediatek/clk-cpumux.h > +++ b/drivers/clk/mediatek/clk-cpumux.h > @@ -7,6 +7,10 @@ > #ifndef __DRV_CLK_CPUMUX_H > #define __DRV_CLK_CPUMUX_H > > +struct clk_onecell_data; > +struct device_node; > +struct mtk_composite; > + > int mtk_clk_register_cpumuxes(struct device_node *node, > const struct mtk_composite *clks, int > num, > struct clk_onecell_data *clk_data);
Quoting Chen-Yu Tsai (2022-02-08 04:40:11) > Some headers with the declaration of functions and structures aren't > directly included. Explicitly include them so that future changes to > other headers would not result in an unexpected build break. > > On the header side, add forward declarations for any data structures > whose pointers are used in function signatures. No headers are > required. > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > Reviewed-by: Miles Chen <miles.chen@mediatek.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- Applied to clk-next
diff --git a/drivers/clk/mediatek/clk-cpumux.c b/drivers/clk/mediatek/clk-cpumux.c index 344c6399b22f..658aee789f44 100644 --- a/drivers/clk/mediatek/clk-cpumux.c +++ b/drivers/clk/mediatek/clk-cpumux.c @@ -5,8 +5,11 @@ */ #include <linux/clk-provider.h> +#include <linux/container_of.h> +#include <linux/err.h> #include <linux/mfd/syscon.h> #include <linux/module.h> +#include <linux/regmap.h> #include <linux/slab.h> #include "clk-mtk.h" diff --git a/drivers/clk/mediatek/clk-cpumux.h b/drivers/clk/mediatek/clk-cpumux.h index a538f2bbef0d..b07e89f7c283 100644 --- a/drivers/clk/mediatek/clk-cpumux.h +++ b/drivers/clk/mediatek/clk-cpumux.h @@ -7,6 +7,10 @@ #ifndef __DRV_CLK_CPUMUX_H #define __DRV_CLK_CPUMUX_H +struct clk_onecell_data; +struct device_node; +struct mtk_composite; + int mtk_clk_register_cpumuxes(struct device_node *node, const struct mtk_composite *clks, int num, struct clk_onecell_data *clk_data);