| Message ID | 20220426093608.2957210-2-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | dt-bindings: clock: sourt out gcc-apq8064 compats | expand |
On Tue, Apr 26, 2022 at 12:36:07PM +0300, Dmitry Baryshkov wrote: > The global clock controller on apq8084 has nothing to do with the schema > for apq8064. It uses the schema defined in qcom,gcc-other.yaml. Move > respective declarations back. > > Instead add what was really meant to be present in qcom,gcc-apq8064 > schema: the compatibility string for qcom,apq8064 device. > > Fixes: a469bf89a009 ("dt-bindings: clock: simplify qcom,gcc-apq8064 Documentation") > Reported-by: Rob Herring <robh@kernel.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 4 +--- > Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml | 3 +++ > 2 files changed, 4 insertions(+), 3 deletions(-) Thanks for sorting this out! Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml index 97936411b6b4..9fafcb080069 100644 --- a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml @@ -20,12 +20,10 @@ description: | See also: - dt-bindings/clock/qcom,gcc-msm8960.h - dt-bindings/reset/qcom,gcc-msm8960.h - - dt-bindings/clock/qcom,gcc-apq8084.h - - dt-bindings/reset/qcom,gcc-apq8084.h properties: compatible: - const: qcom,gcc-apq8084 + const: qcom,gcc-apq8064 nvmem-cells: minItems: 1 diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml index 6c45e0f85494..142402f29d98 100644 --- a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml @@ -15,6 +15,8 @@ description: | power domains. See also: + - dt-bindings/clock/qcom,gcc-apq8084.h + - dt-bindings/reset/qcom,gcc-apq8084.h - dt-bindings/clock/qcom,gcc-ipq4019.h - dt-bindings/clock/qcom,gcc-ipq6018.h - dt-bindings/reset/qcom,gcc-ipq6018.h @@ -36,6 +38,7 @@ allOf: properties: compatible: enum: + - qcom,gcc-apq8084 - qcom,gcc-ipq4019 - qcom,gcc-ipq6018 - qcom,gcc-mdm9607
The global clock controller on apq8084 has nothing to do with the schema for apq8064. It uses the schema defined in qcom,gcc-other.yaml. Move respective declarations back. Instead add what was really meant to be present in qcom,gcc-apq8064 schema: the compatibility string for qcom,apq8064 device. Fixes: a469bf89a009 ("dt-bindings: clock: simplify qcom,gcc-apq8064 Documentation") Reported-by: Rob Herring <robh@kernel.org> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 4 +--- Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml | 3 +++ 2 files changed, 4 insertions(+), 3 deletions(-)