diff mbox series

[v2,2/6] dt-bindings: clock: Add support for IPQ8074 APSS clock controller

Message ID 20220503195605.4015616-2-robimarko@gmail.com (mailing list archive)
State Superseded, archived
Headers show
Series [v2,1/6] clk: qcom: clk-alpha-pll: add support for APSS PLL | expand

Commit Message

Robert Marko May 3, 2022, 7:56 p.m. UTC 
Add dt-binding for the IPQ8074 APSS clock controller which provides
clocks to the CPU cores.

Signed-off-by: Robert Marko <robimarko@gmail.com>
---
Changes in v2:
* Correct subject
---
 include/dt-bindings/clock/qcom,apss-ipq8074.h | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 include/dt-bindings/clock/qcom,apss-ipq8074.h

Comments

Rob Herring (Arm) May 4, 2022, 8:08 p.m. UTC | #1 
On Tue, May 03, 2022 at 09:56:01PM +0200, Robert Marko wrote:
> Add dt-binding for the IPQ8074 APSS clock controller which provides
> clocks to the CPU cores.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
> Changes in v2:
> * Correct subject
> ---
>  include/dt-bindings/clock/qcom,apss-ipq8074.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 include/dt-bindings/clock/qcom,apss-ipq8074.h
> 
> diff --git a/include/dt-bindings/clock/qcom,apss-ipq8074.h b/include/dt-bindings/clock/qcom,apss-ipq8074.h
> new file mode 100644
> index 000000000000..df07766b0146
> --- /dev/null
> +++ b/include/dt-bindings/clock/qcom,apss-ipq8074.h
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

Dual license please.

> +/*
> + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> + */
> +
> +#ifndef _DT_BINDINGS_CLOCK_QCA_APSS_IPQ8074_H
> +#define _DT_BINDINGS_CLOCK_QCA_APSS_IPQ8074_H
> +
> +#define APSS_PLL_EARLY				0
> +#define APSS_PLL				1
> +#define APCS_ALIAS0_CLK_SRC			2
> +#define APCS_ALIAS0_CORE_CLK			3
> +
> +#endif
> -- 
> 2.35.1
> 
>
Robert Marko May 4, 2022, 8:45 p.m. UTC | #2 
On Wed, 4 May 2022 at 22:08, Rob Herring <robh@kernel.org> wrote:
>
> On Tue, May 03, 2022 at 09:56:01PM +0200, Robert Marko wrote:
> > Add dt-binding for the IPQ8074 APSS clock controller which provides
> > clocks to the CPU cores.
> >
> > Signed-off-by: Robert Marko <robimarko@gmail.com>
> > ---
> > Changes in v2:
> > * Correct subject
> > ---
> >  include/dt-bindings/clock/qcom,apss-ipq8074.h | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >  create mode 100644 include/dt-bindings/clock/qcom,apss-ipq8074.h
> >
> > diff --git a/include/dt-bindings/clock/qcom,apss-ipq8074.h b/include/dt-bindings/clock/qcom,apss-ipq8074.h
> > new file mode 100644
> > index 000000000000..df07766b0146
> > --- /dev/null
> > +++ b/include/dt-bindings/clock/qcom,apss-ipq8074.h
> > @@ -0,0 +1,14 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
>
> Dual license please.

Hi Rob,
Krzysztof asked about this in v1, I have derived this off IPQ6018
binding which is marked GPL-2.0.
So, I was not sure if it was appropriate to mark it as GPL/BSD dual license.
If you say that its not an issue to dual-license, I will gladly do it.

Regards,
Robert
>
> > +/*
> > + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> > + */
> > +
> > +#ifndef _DT_BINDINGS_CLOCK_QCA_APSS_IPQ8074_H
> > +#define _DT_BINDINGS_CLOCK_QCA_APSS_IPQ8074_H
> > +
> > +#define APSS_PLL_EARLY                               0
> > +#define APSS_PLL                             1
> > +#define APCS_ALIAS0_CLK_SRC                  2
> > +#define APCS_ALIAS0_CORE_CLK                 3
> > +
> > +#endif
> > --
> > 2.35.1
> >
> >
Rob Herring (Arm) May 9, 2022, 9:12 p.m. UTC | #3 
On Wed, May 04, 2022 at 10:45:22PM +0200, Robert Marko wrote:
> On Wed, 4 May 2022 at 22:08, Rob Herring <robh@kernel.org> wrote:
> >
> > On Tue, May 03, 2022 at 09:56:01PM +0200, Robert Marko wrote:
> > > Add dt-binding for the IPQ8074 APSS clock controller which provides
> > > clocks to the CPU cores.
> > >
> > > Signed-off-by: Robert Marko <robimarko@gmail.com>
> > > ---
> > > Changes in v2:
> > > * Correct subject
> > > ---
> > >  include/dt-bindings/clock/qcom,apss-ipq8074.h | 14 ++++++++++++++
> > >  1 file changed, 14 insertions(+)
> > >  create mode 100644 include/dt-bindings/clock/qcom,apss-ipq8074.h
> > >
> > > diff --git a/include/dt-bindings/clock/qcom,apss-ipq8074.h b/include/dt-bindings/clock/qcom,apss-ipq8074.h
> > > new file mode 100644
> > > index 000000000000..df07766b0146
> > > --- /dev/null
> > > +++ b/include/dt-bindings/clock/qcom,apss-ipq8074.h
> > > @@ -0,0 +1,14 @@
> > > +/* SPDX-License-Identifier: GPL-2.0 */
> >
> > Dual license please.
> 
> Hi Rob,
> Krzysztof asked about this in v1, I have derived this off IPQ6018
> binding which is marked GPL-2.0.
> So, I was not sure if it was appropriate to mark it as GPL/BSD dual license.
> If you say that its not an issue to dual-license, I will gladly do it.

Technically, you should maintain it, but I don't think 2 defines is 
really enough to represent copyrightable work (but IANAL). I also know 
that QCom prefers the DT stuff to be dual licensed because they've 
raised the issue with me. 

Rob
Robert Marko May 10, 2022, 3:58 p.m. UTC | #4 
On Mon, 9 May 2022 at 23:12, Rob Herring <robh@kernel.org> wrote:
>
> On Wed, May 04, 2022 at 10:45:22PM +0200, Robert Marko wrote:
> > On Wed, 4 May 2022 at 22:08, Rob Herring <robh@kernel.org> wrote:
> > >
> > > On Tue, May 03, 2022 at 09:56:01PM +0200, Robert Marko wrote:
> > > > Add dt-binding for the IPQ8074 APSS clock controller which provides
> > > > clocks to the CPU cores.
> > > >
> > > > Signed-off-by: Robert Marko <robimarko@gmail.com>
> > > > ---
> > > > Changes in v2:
> > > > * Correct subject
> > > > ---
> > > >  include/dt-bindings/clock/qcom,apss-ipq8074.h | 14 ++++++++++++++
> > > >  1 file changed, 14 insertions(+)
> > > >  create mode 100644 include/dt-bindings/clock/qcom,apss-ipq8074.h
> > > >
> > > > diff --git a/include/dt-bindings/clock/qcom,apss-ipq8074.h b/include/dt-bindings/clock/qcom,apss-ipq8074.h
> > > > new file mode 100644
> > > > index 000000000000..df07766b0146
> > > > --- /dev/null
> > > > +++ b/include/dt-bindings/clock/qcom,apss-ipq8074.h
> > > > @@ -0,0 +1,14 @@
> > > > +/* SPDX-License-Identifier: GPL-2.0 */
> > >
> > > Dual license please.
> >
> > Hi Rob,
> > Krzysztof asked about this in v1, I have derived this off IPQ6018
> > binding which is marked GPL-2.0.
> > So, I was not sure if it was appropriate to mark it as GPL/BSD dual license.
> > If you say that its not an issue to dual-license, I will gladly do it.
>
> Technically, you should maintain it, but I don't think 2 defines is
> really enough to represent copyrightable work (but IANAL). I also know
> that QCom prefers the DT stuff to be dual licensed because they've
> raised the issue with me.

If that is the case, then I will dual-license it and send in v4 as I
am waiting for
the code portion to get some comments before resending.

Regards,
Robert
>
> Rob
diff mbox series

Patch

diff --git a/include/dt-bindings/clock/qcom,apss-ipq8074.h b/include/dt-bindings/clock/qcom,apss-ipq8074.h
new file mode 100644
index 000000000000..df07766b0146
--- /dev/null
+++ b/include/dt-bindings/clock/qcom,apss-ipq8074.h
@@ -0,0 +1,14 @@ 
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2021, The Linux Foundation. All rights reserved.
+ */
+
+#ifndef _DT_BINDINGS_CLOCK_QCA_APSS_IPQ8074_H
+#define _DT_BINDINGS_CLOCK_QCA_APSS_IPQ8074_H
+
+#define APSS_PLL_EARLY				0
+#define APSS_PLL				1
+#define APCS_ALIAS0_CLK_SRC			2
+#define APCS_ALIAS0_CORE_CLK			3
+
+#endif