| Message ID | 20220518055314.2486-1-shubhrajyoti.datta@xilinx.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | clk: zynqmp: Add a check for NULL pointer | expand |
On 5/18/22 07:53, Shubhrajyoti Datta wrote: > Add a NULL pointer check as clk_hw_get_parent can return NULL. > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > --- > drivers/clk/zynqmp/divider.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/zynqmp/divider.c b/drivers/clk/zynqmp/divider.c > index 422ea79907dd..8d1a21214084 100644 > --- a/drivers/clk/zynqmp/divider.c > +++ b/drivers/clk/zynqmp/divider.c > @@ -120,10 +120,13 @@ static void zynqmp_get_divider2_val(struct clk_hw *hw, > long error = LONG_MAX; > unsigned long div1_prate; > struct clk_hw *div1_parent_hw; > + struct zynqmp_clk_divider *pdivider; > struct clk_hw *div2_parent_hw = clk_hw_get_parent(hw); > - struct zynqmp_clk_divider *pdivider = > - to_zynqmp_clk_divider(div2_parent_hw); > > + if (!div2_parent_hw) > + return; > + > + pdivider = to_zynqmp_clk_divider(div2_parent_hw); > if (!pdivider) > return; > > Acked-by: Michal Simek <michal.simek@amd.com> Thanks, Michal
Quoting Shubhrajyoti Datta (2022-05-17 22:53:14) > Add a NULL pointer check as clk_hw_get_parent can return NULL. > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > --- Applied to clk-next
diff --git a/drivers/clk/zynqmp/divider.c b/drivers/clk/zynqmp/divider.c index 422ea79907dd..8d1a21214084 100644 --- a/drivers/clk/zynqmp/divider.c +++ b/drivers/clk/zynqmp/divider.c @@ -120,10 +120,13 @@ static void zynqmp_get_divider2_val(struct clk_hw *hw, long error = LONG_MAX; unsigned long div1_prate; struct clk_hw *div1_parent_hw; + struct zynqmp_clk_divider *pdivider; struct clk_hw *div2_parent_hw = clk_hw_get_parent(hw); - struct zynqmp_clk_divider *pdivider = - to_zynqmp_clk_divider(div2_parent_hw); + if (!div2_parent_hw) + return; + + pdivider = to_zynqmp_clk_divider(div2_parent_hw); if (!pdivider) return;
Add a NULL pointer check as clk_hw_get_parent can return NULL. Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> --- drivers/clk/zynqmp/divider.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)