diff mbox series

[v5,02/18] clocksource: timer-npcm7xx: Add NPCM845 timer support

Message ID 20220622132302.267010-3-tmaimon77@gmail.com (mailing list archive)
State Superseded, archived
Headers show
Series Introduce Nuvoton Arbel NPCM8XX BMC SoC | expand

Commit Message

Tomer Maimon June 22, 2022, 1:22 p.m. UTC
Add Nuvoton BMC NPCM845 timer support, The NPCM845 uses the same timer
controller as the NPCM750.

Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
---
 drivers/clocksource/timer-npcm7xx.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Arnd Bergmann June 23, 2022, 2:10 p.m. UTC | #1
On Wed, Jun 22, 2022 at 3:22 PM Tomer Maimon <tmaimon77@gmail.com> wrote:
>
> Add Nuvoton BMC NPCM845 timer support, The NPCM845 uses the same timer
> controller as the NPCM750.
>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>

I think I've commented on this before: if the timer is the same, you should not
need any changes to the timer driver, just mark the device node as compatible
with the older model (as well as its own string) in its "compatible"
property and
drop this patch.

        Arnd
diff mbox series

Patch

diff --git a/drivers/clocksource/timer-npcm7xx.c b/drivers/clocksource/timer-npcm7xx.c
index a00520cbb660..1630daad4df5 100644
--- a/drivers/clocksource/timer-npcm7xx.c
+++ b/drivers/clocksource/timer-npcm7xx.c
@@ -210,4 +210,5 @@  static int __init npcm7xx_timer_init(struct device_node *np)
 
 TIMER_OF_DECLARE(wpcm450, "nuvoton,wpcm450-timer", npcm7xx_timer_init);
 TIMER_OF_DECLARE(npcm7xx, "nuvoton,npcm750-timer", npcm7xx_timer_init);
+TIMER_OF_DECLARE(npcm8xx, "nuvoton,npcm845-timer", npcm7xx_timer_init);