diff mbox series

[v2] clk: oxnas: Hold reference returned by of_get_parent()

Message ID 20220628143155.170550-1-windhl@126.com (mailing list archive)
State Accepted, archived
Headers show
Series [v2] clk: oxnas: Hold reference returned by of_get_parent() | expand

Commit Message

Liang He June 28, 2022, 2:31 p.m. UTC 
In oxnas_stdclk_probe(), we need to hold the reference returned by
of_get_parent() and use it to call of_node_put() for refcount
balance.

Fixes: 0bbd72b4c64f ("clk: Add Oxford Semiconductor OXNAS Standard Clocks")
Signed-off-by: Liang He <windhl@126.com>
---
 changelog:

 v2: change 'tp' with 'parent_np', change title format to xx:yy:zz
 v1: hold reference returned by of_get_parent()

 v1-link: https://lore.kernel.org/all/20220624102017.4164778-1-windhl@126.com/

 Patched file has been copmiled test in 5.19rc2.

 drivers/clk/clk-oxnas.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Stephen Boyd Aug. 19, 2022, 9:35 p.m. UTC | #1 
Quoting Liang He (2022-06-28 07:31:55)
> In oxnas_stdclk_probe(), we need to hold the reference returned by
> of_get_parent() and use it to call of_node_put() for refcount
> balance.
> 
> Fixes: 0bbd72b4c64f ("clk: Add Oxford Semiconductor OXNAS Standard Clocks")
> Signed-off-by: Liang He <windhl@126.com>
> ---

Applied to clk-next
diff mbox series

Patch

diff --git a/drivers/clk/clk-oxnas.c b/drivers/clk/clk-oxnas.c
index cda5e258355b..584e293156ad 100644
--- a/drivers/clk/clk-oxnas.c
+++ b/drivers/clk/clk-oxnas.c
@@ -207,7 +207,7 @@  static const struct of_device_id oxnas_stdclk_dt_ids[] = {
 
 static int oxnas_stdclk_probe(struct platform_device *pdev)
 {
-	struct device_node *np = pdev->dev.of_node;
+	struct device_node *np = pdev->dev.of_node, *parent_np;
 	const struct oxnas_stdclk_data *data;
 	struct regmap *regmap;
 	int ret;
@@ -215,7 +215,9 @@  static int oxnas_stdclk_probe(struct platform_device *pdev)
 
 	data = of_device_get_match_data(&pdev->dev);
 
-	regmap = syscon_node_to_regmap(of_get_parent(np));
+	parent_np = of_get_parent(np);
+	regmap = syscon_node_to_regmap(parent_np);
+	of_node_put(parent_np);
 	if (IS_ERR(regmap)) {
 		dev_err(&pdev->dev, "failed to have parent regmap\n");
 		return PTR_ERR(regmap);