| Message ID | 20220726102404.564498-2-gengcixi@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add ums512 clocks and relative bindings file | expand |
On Tue, 26 Jul 2022 18:24:03 +0800, Cixi Geng wrote: > From: Chunyan Zhang <chunyan.zhang@unisoc.com> > > Add bindings for Unisoc system global register which provide register map > for clocks. > > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com> > Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > .../bindings/mfd/sprd,ums512-glbreg.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/clock/sprd,ums512-clk.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.example.dtb: syscon@71000000: clock-controller@0: False schema does not allow {'compatible': ['sprd,ums512-apahb-gate'], 'reg': [[0, 8192]], '#clock-cells': [[1]]} From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.example.dtb:0:0: /example-0/syscon@71000000/clock-controller@0: failed to match any schema with compatible: ['sprd,ums512-apahb-gate'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 26/07/2022 12:24, Cixi Geng wrote: > From: Chunyan Zhang <chunyan.zhang@unisoc.com> > > Add bindings for Unisoc system global register which provide register map > for clocks. > > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com> > Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > .../bindings/mfd/sprd,ums512-glbreg.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml b/Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml > new file mode 100644 > index 000000000000..416f94a09c27 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright 2022 Unisoc Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/sprd,ums512-glbreg.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Unisoc System Global Register > + > +maintainers: > + - Orson Zhai <orsonzhai@gmail.com> > + - Baolin Wang <baolin.wang7@gmail.com> > + - Chunyan Zhang <zhang.lyra@gmail.com> > + > +description: > + Unisoc system global registers provide register map > + for clocks and some multimedia modules of the SoC. > + > +properties: > + compatible: > + items: > + - const: sprd,ums512-glbregs > + - const: syscon > + - const: simple-mfd > + > + "#address-cells": true > + "#size-cells": true > + > + ranges: > + maxItems: 1 > + > + reg: > + maxItems: 1 > + > +patternProperties: > + "^clock-controller@[0-9a-f]+$": > + type: object > + $ref: "../clock/sprd,ums512-clk.yaml" Absolute path (without quotes): /schemas/clock/sprd,ums512-clk.yaml Best regards, Krzysztof
On 26/07/2022 12:24, Cixi Geng wrote: > From: Chunyan Zhang <chunyan.zhang@unisoc.com> > > Add bindings for Unisoc system global register which provide register map > for clocks. > > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com> > Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > .../bindings/mfd/sprd,ums512-glbreg.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml > The patch depends on patch in clk tree, so either it goes via clk tree, there is cross-tree merge or it must wait for v5.20-rc1. Best regards, Krzysztof
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 于2022年7月27日周三 01:48写道： > > On 26/07/2022 12:24, Cixi Geng wrote: > > From: Chunyan Zhang <chunyan.zhang@unisoc.com> > > > > Add bindings for Unisoc system global register which provide register map > > for clocks. > > > > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com> > > Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com> > > Reviewed-by: Rob Herring <robh@kernel.org> > > --- > > .../bindings/mfd/sprd,ums512-glbreg.yaml | 68 +++++++++++++++++++ > > 1 file changed, 68 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml > > > > The patch depends on patch in clk tree, so either it goes via clk tree, > there is cross-tree merge or it must wait for v5.20-rc1. ok, I will resend this patchset after v5.20-rc1.thanks > > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml b/Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml new file mode 100644 index 000000000000..416f94a09c27 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml @@ -0,0 +1,68 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright 2022 Unisoc Inc. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/sprd,ums512-glbreg.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Unisoc System Global Register + +maintainers: + - Orson Zhai <orsonzhai@gmail.com> + - Baolin Wang <baolin.wang7@gmail.com> + - Chunyan Zhang <zhang.lyra@gmail.com> + +description: + Unisoc system global registers provide register map + for clocks and some multimedia modules of the SoC. + +properties: + compatible: + items: + - const: sprd,ums512-glbregs + - const: syscon + - const: simple-mfd + + "#address-cells": true + "#size-cells": true + + ranges: + maxItems: 1 + + reg: + maxItems: 1 + +patternProperties: + "^clock-controller@[0-9a-f]+$": + type: object + $ref: "../clock/sprd,ums512-clk.yaml" + description: + Clock controller for the SoC clocks. + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + ap_apb_regs: syscon@71000000 { + compatible = "sprd,ums512-glbregs", "syscon", "simple-mfd"; + reg = <0x71000000 0x3000>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0 0x71000000 0x3000>; + + clock-controller@0 { + compatible = "sprd,ums512-apahb-gate"; + reg = <0x0 0x2000>; + #clock-cells = <1>; + }; + }; + + - | + ap_intc5_regs: syscon@32360000 { + compatible = "sprd,ums512-glbregs", "syscon", "simple-mfd"; + reg = <0x32360000 0x1000>; + };