diff mbox series

[-next] clk: bulk: Use dev_err_probe() helper in __clk_bulk_get()

Message ID 20220913032403.1007902-1-yangyingliang@huawei.com (mailing list archive)
State Awaiting Upstream, archived
Headers show
Series [-next] clk: bulk: Use dev_err_probe() helper in __clk_bulk_get() | expand

Commit Message

Yang Yingliang Sept. 13, 2022, 3:24 a.m. UTC
dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/clk/clk-bulk.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Stephen Boyd Oct. 17, 2022, 11:07 p.m. UTC | #1
Quoting Yang Yingliang (2022-09-12 20:24:03)
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---

Applied to clk-next
diff mbox series

Patch

diff --git a/drivers/clk/clk-bulk.c b/drivers/clk/clk-bulk.c
index e9e16425c739..826b3ff99433 100644
--- a/drivers/clk/clk-bulk.c
+++ b/drivers/clk/clk-bulk.c
@@ -96,9 +96,9 @@  static int __clk_bulk_get(struct device *dev, int num_clks,
 			if (ret == -ENOENT && optional)
 				continue;
 
-			if (ret != -EPROBE_DEFER)
-				dev_err(dev, "Failed to get clk '%s': %d\n",
-					clks[i].id, ret);
+			dev_err_probe(dev, ret,
+				      "Failed to get clk '%s'\n",
+				      clks[i].id);
 			goto err;
 		}
 	}