| Message ID | 20220930090653.7449-1-hal.feng@linux.starfivetech.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Basic StarFive JH7110 RISC-V SoC support | expand |
On 30/09/2022 10:06, Hal Feng wrote: > Add CONFIG_SERIAL_8250_DW=y, which is a necessary option for > StarFive JH7110 and JH7100 SoCs to boot with serial ports. > > Signed-off-by: Hal Feng <hal.feng@linux.starfivetech.com> That might be useful for other users at some point an I don't think it adds much code. > --- > arch/riscv/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig > index aed332a9d4ea..0c44484cd3a4 100644 > --- a/arch/riscv/configs/defconfig > +++ b/arch/riscv/configs/defconfig > @@ -122,6 +122,7 @@ CONFIG_MICROSEMI_PHY=y > CONFIG_INPUT_MOUSEDEV=y > CONFIG_SERIAL_8250=y > CONFIG_SERIAL_8250_CONSOLE=y > +CONFIG_SERIAL_8250_DW=y > CONFIG_SERIAL_OF_PLATFORM=y > CONFIG_VIRTIO_CONSOLE=y > CONFIG_HW_RANDOM=y
On Fri, Sep 30, 2022 at 09:54:14PM +0100, Ben Dooks wrote: > On 30/09/2022 10:06, Hal Feng wrote: > > Add CONFIG_SERIAL_8250_DW=y, which is a necessary option for > > StarFive JH7110 and JH7100 SoCs to boot with serial ports. > > > > Signed-off-by: Hal Feng <hal.feng@linux.starfivetech.com> > > That might be useful for other users at some point an I don't > think it adds much code. Honestly I think this should be applied for 6.1, for parity with the other SoCs that have their serial console enabled by default. Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > > > --- > > arch/riscv/configs/defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig > > index aed332a9d4ea..0c44484cd3a4 100644 > > --- a/arch/riscv/configs/defconfig > > +++ b/arch/riscv/configs/defconfig > > @@ -122,6 +122,7 @@ CONFIG_MICROSEMI_PHY=y > > CONFIG_INPUT_MOUSEDEV=y > > CONFIG_SERIAL_8250=y > > CONFIG_SERIAL_8250_CONSOLE=y > > +CONFIG_SERIAL_8250_DW=y > > CONFIG_SERIAL_OF_PLATFORM=y > > CONFIG_VIRTIO_CONSOLE=y > > CONFIG_HW_RANDOM=y > > -- > Ben Dooks http://www.codethink.co.uk/ > Senior Engineer Codethink - Providing Genius > > https://www.codethink.co.uk/privacy.html > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
On Fri, 30 Sep 2022 22:41:23 +0100, Conor Dooley wrote: > On Fri, Sep 30, 2022 at 09:54:14PM +0100, Ben Dooks wrote: > > On 30/09/2022 10:06, Hal Feng wrote: > > > Add CONFIG_SERIAL_8250_DW=y, which is a necessary option for > > > StarFive JH7110 and JH7100 SoCs to boot with serial ports. > > > > > > Signed-off-by: Hal Feng <hal.feng@linux.starfivetech.com> > > > > That might be useful for other users at some point an I don't > > think it adds much code. > > Honestly I think this should be applied for 6.1, for parity with the > other SoCs that have their serial console enabled by default. > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Could this patch be pulled out and applied for v6.1? So the JH7100 and the coming JH7110 can enable serial console by default when booting. Thanks. Best regards, Hal
diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig index aed332a9d4ea..0c44484cd3a4 100644 --- a/arch/riscv/configs/defconfig +++ b/arch/riscv/configs/defconfig @@ -122,6 +122,7 @@ CONFIG_MICROSEMI_PHY=y CONFIG_INPUT_MOUSEDEV=y CONFIG_SERIAL_8250=y CONFIG_SERIAL_8250_CONSOLE=y +CONFIG_SERIAL_8250_DW=y CONFIG_SERIAL_OF_PLATFORM=y CONFIG_VIRTIO_CONSOLE=y CONFIG_HW_RANDOM=y
Add CONFIG_SERIAL_8250_DW=y, which is a necessary option for StarFive JH7110 and JH7100 SoCs to boot with serial ports. Signed-off-by: Hal Feng <hal.feng@linux.starfivetech.com> --- arch/riscv/configs/defconfig | 1 + 1 file changed, 1 insertion(+)