| Message ID | 20230113041038.4188995-1-quic_bjorande@quicinc.com (mailing list archive) |
|---|---|
| State | Rejected, archived |
| Headers | show |
| Series | clk: qcom: Remove need for clk_ignore_unused on sc8280xp | expand |
The subject could be more in the likes of "use disable_unused sync_state".. On 13.01.2023 05:10, Bjorn Andersson wrote: > With the transition of disabling unused clocks at sync_state, rather > than late_initcall() it's now possible to drop clk_ignore_unused and > unused clock disabled once client drivers have probed. Do this on > SC8280XP. > > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> > --- Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > drivers/clk/qcom/dispcc-sc8280xp.c | 1 + > drivers/clk/qcom/gcc-sc8280xp.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-sc8280xp.c > index 167470beb369..c84a6481b879 100644 > --- a/drivers/clk/qcom/dispcc-sc8280xp.c > +++ b/drivers/clk/qcom/dispcc-sc8280xp.c > @@ -3199,6 +3199,7 @@ static struct platform_driver disp_cc_sc8280xp_driver = { > .driver = { > .name = "disp_cc-sc8280xp", > .of_match_table = disp_cc_sc8280xp_match_table, > + .sync_state = clk_sync_state_disable_unused, > }, > }; > > diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c > index b3198784e1c3..f4fdc5b9663c 100644 > --- a/drivers/clk/qcom/gcc-sc8280xp.c > +++ b/drivers/clk/qcom/gcc-sc8280xp.c > @@ -7441,6 +7441,7 @@ static struct platform_driver gcc_sc8280xp_driver = { > .driver = { > .name = "gcc-sc8280xp", > .of_match_table = gcc_sc8280xp_match_table, > + .sync_state = clk_sync_state_disable_unused, > }, > }; >
On Thu, Jan 12, 2023 at 08:10:38PM -0800, Bjorn Andersson wrote: > With the transition of disabling unused clocks at sync_state, rather > than late_initcall() it's now possible to drop clk_ignore_unused and > unused clock disabled once client drivers have probed. Do this on > SC8280XP. > > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> Tested-by: Andrew Halaney <ahalaney@redhat.com> # sc8280xp-lenovo-thinkpad-x13s I've booted with this (and without clk_ignore_unused) a few times today and have been working with on the machine without any apparent issues. Thanks! It is nice to have to modify less of the kernel cli to boot. > --- > drivers/clk/qcom/dispcc-sc8280xp.c | 1 + > drivers/clk/qcom/gcc-sc8280xp.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-sc8280xp.c > index 167470beb369..c84a6481b879 100644 > --- a/drivers/clk/qcom/dispcc-sc8280xp.c > +++ b/drivers/clk/qcom/dispcc-sc8280xp.c > @@ -3199,6 +3199,7 @@ static struct platform_driver disp_cc_sc8280xp_driver = { > .driver = { > .name = "disp_cc-sc8280xp", > .of_match_table = disp_cc_sc8280xp_match_table, > + .sync_state = clk_sync_state_disable_unused, > }, > }; > > diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c > index b3198784e1c3..f4fdc5b9663c 100644 > --- a/drivers/clk/qcom/gcc-sc8280xp.c > +++ b/drivers/clk/qcom/gcc-sc8280xp.c > @@ -7441,6 +7441,7 @@ static struct platform_driver gcc_sc8280xp_driver = { > .driver = { > .name = "gcc-sc8280xp", > .of_match_table = gcc_sc8280xp_match_table, > + .sync_state = clk_sync_state_disable_unused, > }, > }; > > -- > 2.37.3 >
On Thu, Jan 12, 2023 at 08:10:38PM -0800, Bjorn Andersson wrote: > With the transition of disabling unused clocks at sync_state, rather > than late_initcall() it's now possible to drop clk_ignore_unused and > unused clock disabled once client drivers have probed. Do this on > SC8280XP. > > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > --- > drivers/clk/qcom/dispcc-sc8280xp.c | 1 + > drivers/clk/qcom/gcc-sc8280xp.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-sc8280xp.c > index 167470beb369..c84a6481b879 100644 > --- a/drivers/clk/qcom/dispcc-sc8280xp.c > +++ b/drivers/clk/qcom/dispcc-sc8280xp.c > @@ -3199,6 +3199,7 @@ static struct platform_driver disp_cc_sc8280xp_driver = { > .driver = { > .name = "disp_cc-sc8280xp", > .of_match_table = disp_cc_sc8280xp_match_table, > + .sync_state = clk_sync_state_disable_unused, > }, > }; > > diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c > index b3198784e1c3..f4fdc5b9663c 100644 > --- a/drivers/clk/qcom/gcc-sc8280xp.c > +++ b/drivers/clk/qcom/gcc-sc8280xp.c > @@ -7441,6 +7441,7 @@ static struct platform_driver gcc_sc8280xp_driver = { > .driver = { > .name = "gcc-sc8280xp", > .of_match_table = gcc_sc8280xp_match_table, > + .sync_state = clk_sync_state_disable_unused, > }, > }; > > -- > 2.37.3 >
On 23-01-12 20:10:38, Bjorn Andersson wrote: > With the transition of disabling unused clocks at sync_state, rather > than late_initcall() it's now possible to drop clk_ignore_unused and > unused clock disabled once client drivers have probed. Do this on > SC8280XP. > > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> Reviewed-by: Abel Vesa <abel.vesa@linaro.org> > --- > drivers/clk/qcom/dispcc-sc8280xp.c | 1 + > drivers/clk/qcom/gcc-sc8280xp.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-sc8280xp.c > index 167470beb369..c84a6481b879 100644 > --- a/drivers/clk/qcom/dispcc-sc8280xp.c > +++ b/drivers/clk/qcom/dispcc-sc8280xp.c > @@ -3199,6 +3199,7 @@ static struct platform_driver disp_cc_sc8280xp_driver = { > .driver = { > .name = "disp_cc-sc8280xp", > .of_match_table = disp_cc_sc8280xp_match_table, > + .sync_state = clk_sync_state_disable_unused, > }, > }; > > diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c > index b3198784e1c3..f4fdc5b9663c 100644 > --- a/drivers/clk/qcom/gcc-sc8280xp.c > +++ b/drivers/clk/qcom/gcc-sc8280xp.c > @@ -7441,6 +7441,7 @@ static struct platform_driver gcc_sc8280xp_driver = { > .driver = { > .name = "gcc-sc8280xp", > .of_match_table = gcc_sc8280xp_match_table, > + .sync_state = clk_sync_state_disable_unused, > }, > }; > > -- > 2.37.3 >
On Thu, 12 Jan 2023 20:10:38 -0800, Bjorn Andersson wrote: > With the transition of disabling unused clocks at sync_state, rather > than late_initcall() it's now possible to drop clk_ignore_unused and > unused clock disabled once client drivers have probed. Do this on > SC8280XP. > > Applied, thanks! [1/1] clk: qcom: Remove need for clk_ignore_unused on sc8280xp commit: 29e31415e14e16e25d428205c7230400dea1d7cf Best regards,
diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-sc8280xp.c index 167470beb369..c84a6481b879 100644 --- a/drivers/clk/qcom/dispcc-sc8280xp.c +++ b/drivers/clk/qcom/dispcc-sc8280xp.c @@ -3199,6 +3199,7 @@ static struct platform_driver disp_cc_sc8280xp_driver = { .driver = { .name = "disp_cc-sc8280xp", .of_match_table = disp_cc_sc8280xp_match_table, + .sync_state = clk_sync_state_disable_unused, }, }; diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c index b3198784e1c3..f4fdc5b9663c 100644 --- a/drivers/clk/qcom/gcc-sc8280xp.c +++ b/drivers/clk/qcom/gcc-sc8280xp.c @@ -7441,6 +7441,7 @@ static struct platform_driver gcc_sc8280xp_driver = { .driver = { .name = "gcc-sc8280xp", .of_match_table = gcc_sc8280xp_match_table, + .sync_state = clk_sync_state_disable_unused, }, };
With the transition of disabling unused clocks at sync_state, rather than late_initcall() it's now possible to drop clk_ignore_unused and unused clock disabled once client drivers have probed. Do this on SC8280XP. Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> --- drivers/clk/qcom/dispcc-sc8280xp.c | 1 + drivers/clk/qcom/gcc-sc8280xp.c | 1 + 2 files changed, 2 insertions(+)