diff mbox series

[1/3] clk: qcom: cpu-8996: add missing cputype include

Message ID 20230123201812.1230039-1-krzysztof.kozlowski@linaro.org (mailing list archive)
State Changes Requested, archived
Headers show
Series [1/3] clk: qcom: cpu-8996: add missing cputype include | expand

Commit Message

Krzysztof Kozlowski Jan. 23, 2023, 8:18 p.m. UTC
Include asm/cputype.h to fix ARMv7 compile test error:

  drivers/clk/qcom/clk-cpu-8996.c: In function ‘qcom_cpu_clk_msm8996_acd_init’:
  drivers/clk/qcom/clk-cpu-8996.c:468:16: error: implicit declaration of function ‘read_cpuid_mpidr’ [-Werror=implicit-function-declaration]

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/clk/qcom/clk-cpu-8996.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Konrad Dybcio Jan. 23, 2023, 8:28 p.m. UTC | #1
On 23.01.2023 21:18, Krzysztof Kozlowski wrote:
> Include asm/cputype.h to fix ARMv7 compile test error:
> 
>   drivers/clk/qcom/clk-cpu-8996.c: In function ‘qcom_cpu_clk_msm8996_acd_init’:
>   drivers/clk/qcom/clk-cpu-8996.c:468:16: error: implicit declaration of function ‘read_cpuid_mpidr’ [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  drivers/clk/qcom/clk-cpu-8996.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/qcom/clk-cpu-8996.c b/drivers/clk/qcom/clk-cpu-8996.c
> index ee76ef958d31..40c4dabc20a7 100644
> --- a/drivers/clk/qcom/clk-cpu-8996.c
> +++ b/drivers/clk/qcom/clk-cpu-8996.c
> @@ -49,6 +49,7 @@
>   * detect voltage droops.
>   */
>  
> +#include <asm/cputype.h>
>  #include <linux/bitfield.h>
>  #include <linux/clk.h>
>  #include <linux/clk-provider.h>
Stephen Boyd Jan. 25, 2023, 8:33 p.m. UTC | #2
Quoting Krzysztof Kozlowski (2023-01-23 12:18:10)
> diff --git a/drivers/clk/qcom/clk-cpu-8996.c b/drivers/clk/qcom/clk-cpu-8996.c
> index ee76ef958d31..40c4dabc20a7 100644
> --- a/drivers/clk/qcom/clk-cpu-8996.c
> +++ b/drivers/clk/qcom/clk-cpu-8996.c
> @@ -49,6 +49,7 @@
>   * detect voltage droops.
>   */
>  
> +#include <asm/cputype.h>

Please include asm headers after linux headers

>  #include <linux/bitfield.h>
>  #include <linux/clk.h>
>  #include <linux/clk-provider.h>
Krzysztof Kozlowski Jan. 26, 2023, 9:32 a.m. UTC | #3
On 25/01/2023 21:33, Stephen Boyd wrote:
> Quoting Krzysztof Kozlowski (2023-01-23 12:18:10)
>> diff --git a/drivers/clk/qcom/clk-cpu-8996.c b/drivers/clk/qcom/clk-cpu-8996.c
>> index ee76ef958d31..40c4dabc20a7 100644
>> --- a/drivers/clk/qcom/clk-cpu-8996.c
>> +++ b/drivers/clk/qcom/clk-cpu-8996.c
>> @@ -49,6 +49,7 @@
>>   * detect voltage droops.
>>   */
>>  
>> +#include <asm/cputype.h>
> 
> Please include asm headers after linux headers

Ack

Best regards,
Krzysztof
Bjorn Andersson Feb. 9, 2023, 4:23 a.m. UTC | #4
On Mon, 23 Jan 2023 21:18:10 +0100, Krzysztof Kozlowski wrote:
> Include asm/cputype.h to fix ARMv7 compile test error:
> 
>   drivers/clk/qcom/clk-cpu-8996.c: In function ‘qcom_cpu_clk_msm8996_acd_init’:
>   drivers/clk/qcom/clk-cpu-8996.c:468:16: error: implicit declaration of function ‘read_cpuid_mpidr’ [-Werror=implicit-function-declaration]
> 
> 

Applied, thanks!

[1/3] clk: qcom: cpu-8996: add missing cputype include
      commit: 5930196eec0d5dc454db6418d82dcfb094c93373
[2/3] clk: qcom: gcc-qcs404: fix duplicated num_parents
      (no commit info)
[3/3] clk: qcom: rpmh: fix double RPMH_IPA_CLK assignment
      (no commit info)

Best regards,
diff mbox series

Patch

diff --git a/drivers/clk/qcom/clk-cpu-8996.c b/drivers/clk/qcom/clk-cpu-8996.c
index ee76ef958d31..40c4dabc20a7 100644
--- a/drivers/clk/qcom/clk-cpu-8996.c
+++ b/drivers/clk/qcom/clk-cpu-8996.c
@@ -49,6 +49,7 @@ 
  * detect voltage droops.
  */
 
+#include <asm/cputype.h>
 #include <linux/bitfield.h>
 #include <linux/clk.h>
 #include <linux/clk-provider.h>