From patchwork Fri Feb 17 08:07:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kathiravan Thirumoorthy X-Patchwork-Id: 13144405 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E58AEC636D4 for ; Fri, 17 Feb 2023 08:07:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229520AbjBQIH6 (ORCPT ); Fri, 17 Feb 2023 03:07:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbjBQIHw (ORCPT ); Fri, 17 Feb 2023 03:07:52 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08F515D3D5; Fri, 17 Feb 2023 00:07:46 -0800 (PST) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31H7Jg3t010504; Fri, 17 Feb 2023 08:07:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=qcppdkim1; bh=6Uo3fDd/EIub4Kcl0EYseEQ8AVFKdTntS4QZgFBZh0o=; b=ev+XDbyxt9MX79LDr6TtAgiHO5njqNVBDr1mT+7MB5Xam9t9D1n0LgWS/2xf7kl0+t+q Noe9Wcncri9KEV48d9Mlst3hoVbg13uSKeM/xCdiSX2WUA3JJ0w0GezHFVmOfTVuKL/l aU1W9FGk46aKBF2UbX89WOMgXg3GoEYHEIh/w/9E/KhDJjtX53FQmyFuKnrOzSksKFE/ 99qnaaZ/+FZHLSFmUXVp7BxhNAeH3E69BCyzEmobNJy58/ghKR0LnzNtGxUKVuw6K2d9 MQ1DgqvUQdhA2x1X7mtWfY6IOTOO6P0sgqYu5DPo2acT1umwcD/wy18I63wig6c9hBjV WA== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3nt53br3qr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Feb 2023 08:07:40 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31H87ddk028727 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Feb 2023 08:07:39 GMT Received: from kathirav-linux.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Fri, 17 Feb 2023 00:07:36 -0800 From: Kathiravan T To: Stephen Boyd , , , , , , , CC: , , Kathiravan T Subject: [PATCH V3] clk: qcom: ipq5332: mark GPLL4 as critical temporarily Date: Fri, 17 Feb 2023 13:37:20 +0530 Message-ID: <20230217080720.5206-1-quic_kathirav@quicinc.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: dvIaN0t9bkSWGucrAvxmlR08jsYL6oQP X-Proofpoint-GUID: dvIaN0t9bkSWGucrAvxmlR08jsYL6oQP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-17_04,2023-02-16_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 suspectscore=0 adultscore=0 impostorscore=0 priorityscore=1501 phishscore=0 mlxlogscore=888 spamscore=0 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302170073 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Clock framework disables the GPLL4 source since there are no active users for this source currently. Some of the clocks initialized by the bootloaders uses the GPLL4 as the source. Due to this, when the GPLL4 is disabled by the clock framework, system is going for the reboot. To avoid this, mark the GPLL4 as CRITICAL so that clock framework doesn't disable it. Once the users of this source is enabled, we can get rid of this flag. Signed-off-by: Kathiravan T --- Changes in V3: - Fixed the typo in the comment - Used CLK_IGNORE_UNUSED instead of CLK_IS_CRITICAL Changes in V2: - Added a comment in driver explaining the need of the flag drivers/clk/qcom/gcc-ipq5332.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/clk/qcom/gcc-ipq5332.c b/drivers/clk/qcom/gcc-ipq5332.c index 9e4baea33937..bea1194b666a 100644 --- a/drivers/clk/qcom/gcc-ipq5332.c +++ b/drivers/clk/qcom/gcc-ipq5332.c @@ -128,6 +128,16 @@ static struct clk_alpha_pll gpll4_main = { .parent_data = &gcc_parent_data_xo, .num_parents = 1, .ops = &clk_alpha_pll_stromer_ops, + /* + * There are no consumers for this GPLL in kernel yet, + * (will be added soon), so the clock framework + * disables this source. But some of the clocks + * initialized by boot loaders uses this source. So we + * need to keep this clock ON. Add the CRITICAL flag + * so the clock will not be disabled. Once the consumer + * in kernel is added, we can get rid of this flag. + */ + .flags = CLK_IGNORE_UNUSED, }, }, };