Message ID | 20230220150111.77897-40-angelogioacchino.delregno@collabora.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers | show |
Series | MediaTek clocks: full module build and cleanups | expand |
On Mon, Feb 20, 2023 at 11:02 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > MT8195 clock drivers were encapsulated in one single (and big) Kconfig > option: there's no reason to do that, as it is totally unnecessary to > build in all or none of them. > > Split them out: keep boot-critical clocks as bool and allow choosing > non critical clocks as tristate. > > As a note, the dependencies of VDEC/VENCSYS and CAM/IMG/IPE/WPESYS > are not for build-time but rather for runtime, as clocks registered > by those have runtime dependencies on either or both VPP and IMGSYS. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > drivers/clk/mediatek/Kconfig | 100 ++++++++++++++++++++++++++++++++++ > drivers/clk/mediatek/Makefile | 20 ++++--- > 2 files changed, 113 insertions(+), 7 deletions(-) > > diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig > index 45b7aea7648d..49919da2be26 100644 > --- a/drivers/clk/mediatek/Kconfig > +++ b/drivers/clk/mediatek/Kconfig > @@ -692,6 +692,106 @@ config COMMON_CLK_MT8195 > help > This driver supports MediaTek MT8195 clocks. > > +config COMMON_CLK_MT8195_APUSYS > + tristate "Clock driver for MediaTek MT8195 apusys" > + depends on COMMON_CLK_MT8195 > + default COMMON_CLK_MT8195 > + help > + This driver supports MediaTek MT8195 AI Processor Unit System clocks. > + > +config COMMON_CLK_MT8195_AUDSYS > + tristate "Clock driver for MediaTek MT8195 audsys" > + depends on COMMON_CLK_MT8195 > + default COMMON_CLK_MT8195 > + help > + This driver supports MediaTek MT8195 audsys clocks. > + > +config COMMON_CLK_MT8195_IMP_IIC_WRAP > + tristate "Clock driver for MediaTek MT8195 imp_iic_wrap" > + depends on COMMON_CLK_MT8195 > + default COMMON_CLK_MT8195 > + help > + This driver supports MediaTek MT8195 I2C/I3C clocks. > + > +config COMMON_CLK_MT8195_IPESYS > + tristate "Clock driver for MediaTek MT8195 ipesys" > + depends on COMMON_CLK_MT8195_IMGSYS This should also be moved to just after IMGSYS. This is the only one that is not ordered right, so after it is fixed, Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Il 21/02/23 04:53, Chen-Yu Tsai ha scritto: > On Mon, Feb 20, 2023 at 11:02 PM AngeloGioacchino Del Regno > <angelogioacchino.delregno@collabora.com> wrote: >> >> MT8195 clock drivers were encapsulated in one single (and big) Kconfig >> option: there's no reason to do that, as it is totally unnecessary to >> build in all or none of them. >> >> Split them out: keep boot-critical clocks as bool and allow choosing >> non critical clocks as tristate. >> >> As a note, the dependencies of VDEC/VENCSYS and CAM/IMG/IPE/WPESYS >> are not for build-time but rather for runtime, as clocks registered >> by those have runtime dependencies on either or both VPP and IMGSYS. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> drivers/clk/mediatek/Kconfig | 100 ++++++++++++++++++++++++++++++++++ >> drivers/clk/mediatek/Makefile | 20 ++++--- >> 2 files changed, 113 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig >> index 45b7aea7648d..49919da2be26 100644 >> --- a/drivers/clk/mediatek/Kconfig >> +++ b/drivers/clk/mediatek/Kconfig >> @@ -692,6 +692,106 @@ config COMMON_CLK_MT8195 >> help >> This driver supports MediaTek MT8195 clocks. >> >> +config COMMON_CLK_MT8195_APUSYS >> + tristate "Clock driver for MediaTek MT8195 apusys" >> + depends on COMMON_CLK_MT8195 >> + default COMMON_CLK_MT8195 >> + help >> + This driver supports MediaTek MT8195 AI Processor Unit System clocks. >> + >> +config COMMON_CLK_MT8195_AUDSYS >> + tristate "Clock driver for MediaTek MT8195 audsys" >> + depends on COMMON_CLK_MT8195 >> + default COMMON_CLK_MT8195 >> + help >> + This driver supports MediaTek MT8195 audsys clocks. >> + >> +config COMMON_CLK_MT8195_IMP_IIC_WRAP >> + tristate "Clock driver for MediaTek MT8195 imp_iic_wrap" >> + depends on COMMON_CLK_MT8195 >> + default COMMON_CLK_MT8195 >> + help >> + This driver supports MediaTek MT8195 I2C/I3C clocks. >> + >> +config COMMON_CLK_MT8195_IPESYS >> + tristate "Clock driver for MediaTek MT8195 ipesys" >> + depends on COMMON_CLK_MT8195_IMGSYS > > This should also be moved to just after IMGSYS. > This is the only one that is not ordered right, so after it is fixed, > Big embarassing oops. Done for v4. > Reviewed-by: Chen-Yu Tsai <wenst@chromium.org> Thanks!
diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig index 45b7aea7648d..49919da2be26 100644 --- a/drivers/clk/mediatek/Kconfig +++ b/drivers/clk/mediatek/Kconfig @@ -692,6 +692,106 @@ config COMMON_CLK_MT8195 help This driver supports MediaTek MT8195 clocks. +config COMMON_CLK_MT8195_APUSYS + tristate "Clock driver for MediaTek MT8195 apusys" + depends on COMMON_CLK_MT8195 + default COMMON_CLK_MT8195 + help + This driver supports MediaTek MT8195 AI Processor Unit System clocks. + +config COMMON_CLK_MT8195_AUDSYS + tristate "Clock driver for MediaTek MT8195 audsys" + depends on COMMON_CLK_MT8195 + default COMMON_CLK_MT8195 + help + This driver supports MediaTek MT8195 audsys clocks. + +config COMMON_CLK_MT8195_IMP_IIC_WRAP + tristate "Clock driver for MediaTek MT8195 imp_iic_wrap" + depends on COMMON_CLK_MT8195 + default COMMON_CLK_MT8195 + help + This driver supports MediaTek MT8195 I2C/I3C clocks. + +config COMMON_CLK_MT8195_IPESYS + tristate "Clock driver for MediaTek MT8195 ipesys" + depends on COMMON_CLK_MT8195_IMGSYS + default COMMON_CLK_MT8195 + help + This driver supports MediaTek MT8195 ipesys clocks. + +config COMMON_CLK_MT8195_MFGCFG + tristate "Clock driver for MediaTek MT8195 mfgcfg" + depends on COMMON_CLK_MT8195 + default COMMON_CLK_MT8195 + help + This driver supports MediaTek MT8195 mfgcfg clocks. + +config COMMON_CLK_MT8195_MSDC + tristate "Clock driver for MediaTek MT8195 msdc" + depends on COMMON_CLK_MT8195 + default COMMON_CLK_MT8195 + help + This driver supports MediaTek MT8195 MMC and SD Controller's + msdc and msdc_top clocks. + +config COMMON_CLK_MT8195_SCP_ADSP + tristate "Clock driver for MediaTek MT8195 scp_adsp" + depends on COMMON_CLK_MT8195 + default COMMON_CLK_MT8195 + help + This driver supports MediaTek MT8195 System Companion Processor + Audio DSP clocks. + +config COMMON_CLK_MT8195_VDOSYS + tristate "Clock driver for MediaTek MT8195 vdosys" + depends on COMMON_CLK_MT8195 + default COMMON_CLK_MT8195 + help + This driver supports MediaTek MT8195 vdosys0/1 (multimedia) clocks. + +config COMMON_CLK_MT8195_VPPSYS + tristate "Clock driver for MediaTek MT8195 vppsys" + depends on COMMON_CLK_MT8195 + default COMMON_CLK_MT8195 + help + This driver supports MediaTek MT8195 vppsys0/1 clocks. + +config COMMON_CLK_MT8195_CAMSYS + tristate "Clock driver for MediaTek MT8195 camsys" + depends on COMMON_CLK_MT8195_VPPSYS + default COMMON_CLK_MT8195_VPPSYS + help + This driver supports MediaTek MT8195 camsys and camsys_raw clocks. + +config COMMON_CLK_MT8195_IMGSYS + tristate "Clock driver for MediaTek MT8195 imgsys" + depends on COMMON_CLK_MT8195_VPPSYS + default COMMON_CLK_MT8195_VPPSYS + help + This driver supports MediaTek MT8195 imgsys and imgsys2 clocks. + +config COMMON_CLK_MT8195_WPESYS + tristate "Clock driver for MediaTek MT8195 wpesys" + depends on COMMON_CLK_MT8195_IMGSYS + default COMMON_CLK_MT8195_IMGSYS + help + This driver supports MediaTek MT8195 Warp Engine clocks. + +config COMMON_CLK_MT8195_VDECSYS + tristate "Clock driver for MediaTek MT8195 vdecsys" + depends on COMMON_CLK_MT8195_VPPSYS + default COMMON_CLK_MT8195_VPPSYS + help + This driver supports MediaTek MT8195 vdecsys and vdecsys_soc clocks. + +config COMMON_CLK_MT8195_VENCSYS + tristate "Clock driver for MediaTek MT8195 vencsys" + depends on COMMON_CLK_MT8195_VPPSYS + default COMMON_CLK_MT8195_VPPSYS + help + This driver supports MediaTek MT8195 vencsys clocks. + config COMMON_CLK_MT8365 tristate "Clock driver for MediaTek MT8365" depends on ARCH_MEDIATEK || COMPILE_TEST diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile index 3133ad8c2028..63351957f862 100644 --- a/drivers/clk/mediatek/Makefile +++ b/drivers/clk/mediatek/Makefile @@ -106,13 +106,19 @@ obj-$(CONFIG_COMMON_CLK_MT8192_SCP_ADSP) += clk-mt8192-scp_adsp.o obj-$(CONFIG_COMMON_CLK_MT8192_VDECSYS) += clk-mt8192-vdec.o obj-$(CONFIG_COMMON_CLK_MT8192_VENCSYS) += clk-mt8192-venc.o obj-$(CONFIG_COMMON_CLK_MT8195) += clk-mt8195-apmixedsys.o clk-mt8195-topckgen.o \ - clk-mt8195-peri_ao.o clk-mt8195-infra_ao.o \ - clk-mt8195-cam.o clk-mt8195-ccu.o clk-mt8195-img.o \ - clk-mt8195-ipe.o clk-mt8195-mfg.o clk-mt8195-scp_adsp.o \ - clk-mt8195-vdec.o clk-mt8195-vdo0.o clk-mt8195-vdo1.o \ - clk-mt8195-venc.o clk-mt8195-vpp0.o clk-mt8195-vpp1.o \ - clk-mt8195-wpe.o clk-mt8195-imp_iic_wrap.o \ - clk-mt8195-apusys_pll.o + clk-mt8195-peri_ao.o clk-mt8195-infra_ao.o +obj-$(CONFIG_COMMON_CLK_MT8195_APUSYS) += clk-mt8195-apusys_pll.o +obj-$(CONFIG_COMMON_CLK_MT8195_CAMSYS) += clk-mt8195-cam.o clk-mt8195-ccu.o +obj-$(CONFIG_COMMON_CLK_MT8195_IMGSYS) += clk-mt8195-img.o +obj-$(CONFIG_COMMON_CLK_MT8195_IMP_IIC_WRAP) += clk-mt8195-imp_iic_wrap.o +obj-$(CONFIG_COMMON_CLK_MT8195_IPESYS) += clk-mt8195-ipe.o +obj-$(CONFIG_COMMON_CLK_MT8195_MFGCFG) += clk-mt8195-mfg.o +obj-$(CONFIG_COMMON_CLK_MT8195_SCP_ADSP) += clk-mt8195-scp_adsp.o +obj-$(CONFIG_COMMON_CLK_MT8195_VDECSYS) += clk-mt8195-vdec.o +obj-$(CONFIG_COMMON_CLK_MT8195_VDOSYS) += clk-mt8195-vdo0.o clk-mt8195-vdo1.o +obj-$(CONFIG_COMMON_CLK_MT8195_VENCSYS) += clk-mt8195-venc.o +obj-$(CONFIG_COMMON_CLK_MT8195_VPPSYS) += clk-mt8195-vpp0.o clk-mt8195-vpp1.o +obj-$(CONFIG_COMMON_CLK_MT8195_WPESYS) += clk-mt8195-wpe.o obj-$(CONFIG_COMMON_CLK_MT8365) += clk-mt8365.o clk-mt8365-apmixedsys.o obj-$(CONFIG_COMMON_CLK_MT8365_APU) += clk-mt8365-apu.o obj-$(CONFIG_COMMON_CLK_MT8365_CAM) += clk-mt8365-cam.o
MT8195 clock drivers were encapsulated in one single (and big) Kconfig option: there's no reason to do that, as it is totally unnecessary to build in all or none of them. Split them out: keep boot-critical clocks as bool and allow choosing non critical clocks as tristate. As a note, the dependencies of VDEC/VENCSYS and CAM/IMG/IPE/WPESYS are not for build-time but rather for runtime, as clocks registered by those have runtime dependencies on either or both VPP and IMGSYS. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- drivers/clk/mediatek/Kconfig | 100 ++++++++++++++++++++++++++++++++++ drivers/clk/mediatek/Makefile | 20 ++++--- 2 files changed, 113 insertions(+), 7 deletions(-)