| Message ID | 20230301020122.3389102-1-peng.fan@oss.nxp.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: clock: imx8m: add interrupts property | expand |
> Subject: [PATCH] dt-bindings: clock: imx8m: add interrupts property > > From: Peng Fan <peng.fan@nxp.com> > > Since the CCM module could trigger interrupt, so add interrupts property for > i.MX8M. > Any chance that these interrupt will be used? More likely such interrupt are useless and has no details about how to use it in RM, just piece of words in the interrupt table. BR > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > Documentation/devicetree/bindings/clock/imx8m-clock.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > index 0dbc1433fede..ac7ad8459c79 100644 > --- a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > +++ b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > @@ -39,6 +39,10 @@ properties: > ID in its "clocks" phandle cell. See > include/dt-bindings/clock/imx8m-clock.h > for the full list of i.MX8M clock IDs. > > + interrupts: > + minItems: 1 > + maxItems: 2 > + > required: > - compatible > - reg > -- > 2.37.1
> Subject: RE: [PATCH] dt-bindings: clock: imx8m: add interrupts property > > > Subject: [PATCH] dt-bindings: clock: imx8m: add interrupts property > > > > From: Peng Fan <peng.fan@nxp.com> > > > > Since the CCM module could trigger interrupt, so add interrupts > > property for i.MX8M. > > > > Any chance that these interrupt will be used? More likely such interrupt are > useless and has no details about how to use it in RM, just piece of words in > the interrupt table. This is to clear the System-Ready check warning. This is to describe the hardware. Since device tree already has it, and the hardware indeed supports interrupt, so let's add it. Thanks, Peng. > > BR > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > Documentation/devicetree/bindings/clock/imx8m-clock.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > > b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > > index 0dbc1433fede..ac7ad8459c79 100644 > > --- a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > > +++ b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > > @@ -39,6 +39,10 @@ properties: > > ID in its "clocks" phandle cell. See > > include/dt-bindings/clock/imx8m-clock.h > > for the full list of i.MX8M clock IDs. > > > > + interrupts: > > + minItems: 1 > > + maxItems: 2 > > + > > required: > > - compatible > > - reg > > -- > > 2.37.1
> Subject: RE: [PATCH] dt-bindings: clock: imx8m: add interrupts property > > > Subject: RE: [PATCH] dt-bindings: clock: imx8m: add interrupts > > property > > > > > Subject: [PATCH] dt-bindings: clock: imx8m: add interrupts property > > > > > > From: Peng Fan <peng.fan@nxp.com> > > > > > > Since the CCM module could trigger interrupt, so add interrupts > > > property for i.MX8M. > > > > > > > Any chance that these interrupt will be used? More likely such > > interrupt are useless and has no details about how to use it in RM, > > just piece of words in the interrupt table. > > This is to clear the System-Ready check warning. This is to describe the > hardware. Since device tree already has it, and the hardware indeed supports > interrupt, so let's add it. > Ok, got it, thx. BR > Thanks, > Peng. > > > > BR > > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > > --- > > > Documentation/devicetree/bindings/clock/imx8m-clock.yaml | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > > > b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > > > index 0dbc1433fede..ac7ad8459c79 100644 > > > --- a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > > > +++ b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > > > @@ -39,6 +39,10 @@ properties: > > > ID in its "clocks" phandle cell. See > > > include/dt-bindings/clock/imx8m-clock.h > > > for the full list of i.MX8M clock IDs. > > > > > > + interrupts: > > > + minItems: 1 > > > + maxItems: 2 > > > + > > > required: > > > - compatible > > > - reg > > > -- > > > 2.37.1
On 01/03/2023 03:01, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > Since the CCM module could trigger interrupt, so add interrupts property > for i.MX8M. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > Documentation/devicetree/bindings/clock/imx8m-clock.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > index 0dbc1433fede..ac7ad8459c79 100644 > --- a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > +++ b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > @@ -39,6 +39,10 @@ properties: > ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx8m-clock.h > for the full list of i.MX8M clock IDs. > > + interrupts: > + minItems: 1 > + maxItems: 2 You should describe the interrupts. Why they are variable in number? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml index 0dbc1433fede..ac7ad8459c79 100644 --- a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml +++ b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml @@ -39,6 +39,10 @@ properties: ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx8m-clock.h for the full list of i.MX8M clock IDs. + interrupts: + minItems: 1 + maxItems: 2 + required: - compatible - reg