diff mbox series

dt-bindings: clock: qcom,gcc-msm8953: split to separate schema

Message ID 20230408143729.84097-1-krzysztof.kozlowski@linaro.org (mailing list archive)
State Awaiting Upstream, archived
Headers show
Series dt-bindings: clock: qcom,gcc-msm8953: split to separate schema | expand

Commit Message

Krzysztof Kozlowski April 8, 2023, 2:37 p.m. UTC
The Qualcomm MSM8953 GCC clock controller has clock inputs, thus
existing gcc-other.yaml was not describing it fully.  Move the binding
to its own schema file and document the clocks based on DTS.  Add driver
contributors as its maintainers.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../bindings/clock/qcom,gcc-msm8953.yaml      | 73 +++++++++++++++++++
 .../bindings/clock/qcom,gcc-other.yaml        |  1 -
 2 files changed, 73 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-msm8953.yaml

Comments

Rob Herring (Arm) April 12, 2023, 3:17 p.m. UTC | #1
On Sat, 08 Apr 2023 16:37:29 +0200, Krzysztof Kozlowski wrote:
> The Qualcomm MSM8953 GCC clock controller has clock inputs, thus
> existing gcc-other.yaml was not describing it fully.  Move the binding
> to its own schema file and document the clocks based on DTS.  Add driver
> contributors as its maintainers.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../bindings/clock/qcom,gcc-msm8953.yaml      | 73 +++++++++++++++++++
>  .../bindings/clock/qcom,gcc-other.yaml        |  1 -
>  2 files changed, 73 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-msm8953.yaml
> 

Acked-by: Rob Herring <robh@kernel.org>
Bjorn Andersson May 25, 2023, 4:54 a.m. UTC | #2
On Sat, 8 Apr 2023 16:37:29 +0200, Krzysztof Kozlowski wrote:
> The Qualcomm MSM8953 GCC clock controller has clock inputs, thus
> existing gcc-other.yaml was not describing it fully.  Move the binding
> to its own schema file and document the clocks based on DTS.  Add driver
> contributors as its maintainers.
> 
> 

Applied, thanks!

[1/1] dt-bindings: clock: qcom,gcc-msm8953: split to separate schema
      commit: 2f9b2096465da9f7eada1c3b297689b666a015cf

Best regards,
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-msm8953.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8953.yaml
new file mode 100644
index 000000000000..fe9fd4cb185f
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8953.yaml
@@ -0,0 +1,73 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/qcom,gcc-msm8953.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Global Clock & Reset Controller on MSM8953
+
+maintainers:
+  - Adam Skladowski <a_skl39@protonmail.com>
+  - Sireesh Kodali <sireeshkodali@protonmail.com>
+
+description: |
+  Qualcomm global clock control module provides the clocks, resets and power
+  domains on MSM8953.
+
+  See also: include/dt-bindings/clock/qcom,gcc-msm8953.h
+
+properties:
+  compatible:
+    const: qcom,gcc-msm8953
+
+  clocks:
+    items:
+      - description: Board XO source
+      - description: Sleep clock source
+      - description: Byte clock from DSI PHY0
+      - description: Pixel clock from DSI PHY0
+      - description: Byte clock from DSI PHY1
+      - description: Pixel clock from DSI PHY1
+
+  clock-names:
+    items:
+      - const: xo
+      - const: sleep
+      - const: dsi0pll
+      - const: dsi0pllbyte
+      - const: dsi1pll
+      - const: dsi1pllbyte
+
+required:
+  - compatible
+  - clocks
+  - clock-names
+
+allOf:
+  - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/qcom,rpmcc.h>
+
+    clock-controller@1800000 {
+        compatible = "qcom,gcc-msm8953";
+        reg = <0x01800000 0x80000>;
+        clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>,
+                 <&sleep_clk>,
+                 <&dsi0_phy 1>,
+                 <&dsi0_phy 0>,
+                 <&dsi1_phy 1>,
+                 <&dsi1_phy 0>;
+        clock-names = "xo",
+                      "sleep",
+                      "dsi0pll",
+                      "dsi0pllbyte",
+                      "dsi1pll",
+                      "dsi1pllbyte";
+        #clock-cells = <1>;
+        #reset-cells = <1>;
+        #power-domain-cells = <1>;
+    };
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml
index ae01e7749534..ba969e7a57bf 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml
@@ -30,7 +30,6 @@  properties:
     enum:
       - qcom,gcc-ipq6018
       - qcom,gcc-mdm9607
-      - qcom,gcc-msm8953
       - qcom,gcc-mdm9615
 
 required: