| Message ID | 20230507175335.2321503-1-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Awaiting Upstream, archived |
| Headers | show |
| Series | [1/2] clk: qcom: mmcc-msm8974: use clk_rcg2_shared_ops for mdp_clk_src clock | expand |
On 7.05.2023 19:53, Dmitry Baryshkov wrote: > The mdp_clk_src clock should not be turned off. Instead it should be > 'parked' to the XO, as most of other mdp_clk_src clocks. Fix that by > using the clk_rcg2_shared_ops. > > Fixes: d8b212014e69 ("clk: qcom: Add support for MSM8974's multimedia clock controller (MMCC)") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- I am inclined to think it's true, however I can't see any evidence of this being done on the vendor kernel.. I am however not a licensed archaeologist so I might have missed it.. Hence I'll do: Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > drivers/clk/qcom/mmcc-msm8974.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/mmcc-msm8974.c b/drivers/clk/qcom/mmcc-msm8974.c > index 4273fce9a4a4..aa29c79fcd55 100644 > --- a/drivers/clk/qcom/mmcc-msm8974.c > +++ b/drivers/clk/qcom/mmcc-msm8974.c > @@ -485,7 +485,7 @@ static struct clk_rcg2 mdp_clk_src = { > .name = "mdp_clk_src", > .parent_data = mmcc_xo_mmpll0_dsi_hdmi_gpll0, > .num_parents = ARRAY_SIZE(mmcc_xo_mmpll0_dsi_hdmi_gpll0), > - .ops = &clk_rcg2_ops, > + .ops = &clk_rcg2_shared_ops, > }, > }; >
On 08/05/2023 10:55, Konrad Dybcio wrote: > > > On 7.05.2023 19:53, Dmitry Baryshkov wrote: >> The mdp_clk_src clock should not be turned off. Instead it should be >> 'parked' to the XO, as most of other mdp_clk_src clocks. Fix that by >> using the clk_rcg2_shared_ops. >> >> Fixes: d8b212014e69 ("clk: qcom: Add support for MSM8974's multimedia clock controller (MMCC)") >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> --- > I am inclined to think it's true, however I can't see any evidence > of this being done on the vendor kernel.. I am however not a licensed > archaeologist so I might have missed it.. Hence I'll do: I have been observing the 'clock stuck at off' without this change. The warning goes away with this patch. Thus I suppose it is correct. > > Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > Konrad >> drivers/clk/qcom/mmcc-msm8974.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/clk/qcom/mmcc-msm8974.c b/drivers/clk/qcom/mmcc-msm8974.c >> index 4273fce9a4a4..aa29c79fcd55 100644 >> --- a/drivers/clk/qcom/mmcc-msm8974.c >> +++ b/drivers/clk/qcom/mmcc-msm8974.c >> @@ -485,7 +485,7 @@ static struct clk_rcg2 mdp_clk_src = { >> .name = "mdp_clk_src", >> .parent_data = mmcc_xo_mmpll0_dsi_hdmi_gpll0, >> .num_parents = ARRAY_SIZE(mmcc_xo_mmpll0_dsi_hdmi_gpll0), >> - .ops = &clk_rcg2_ops, >> + .ops = &clk_rcg2_shared_ops, >> }, >> }; >>
On Sonntag, 7. Mai 2023 19:53:34 CEST Dmitry Baryshkov wrote: > The mdp_clk_src clock should not be turned off. Instead it should be > 'parked' to the XO, as most of other mdp_clk_src clocks. Fix that by > using the clk_rcg2_shared_ops. While I don't recall seeing problems with this clock before, with this change it also seems to be work fine on FP2. Tested-by: Luca Weiss <luca@z3ntu.xyz> > > Fixes: d8b212014e69 ("clk: qcom: Add support for MSM8974's multimedia clock > controller (MMCC)") Signed-off-by: Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> > --- > drivers/clk/qcom/mmcc-msm8974.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/mmcc-msm8974.c > b/drivers/clk/qcom/mmcc-msm8974.c index 4273fce9a4a4..aa29c79fcd55 100644 > --- a/drivers/clk/qcom/mmcc-msm8974.c > +++ b/drivers/clk/qcom/mmcc-msm8974.c > @@ -485,7 +485,7 @@ static struct clk_rcg2 mdp_clk_src = { > .name = "mdp_clk_src", > .parent_data = mmcc_xo_mmpll0_dsi_hdmi_gpll0, > .num_parents = ARRAY_SIZE(mmcc_xo_mmpll0_dsi_hdmi_gpll0), > - .ops = &clk_rcg2_ops, > + .ops = &clk_rcg2_shared_ops, > }, > };
On Sun, 7 May 2023 20:53:34 +0300, Dmitry Baryshkov wrote: > The mdp_clk_src clock should not be turned off. Instead it should be > 'parked' to the XO, as most of other mdp_clk_src clocks. Fix that by > using the clk_rcg2_shared_ops. > > Applied, thanks! [1/2] clk: qcom: mmcc-msm8974: use clk_rcg2_shared_ops for mdp_clk_src clock commit: 8fd492e77ff71f68f7311c22f7bc960182465cd7 Best regards,
On Sun, 07 May 2023 20:53:34 +0300, Dmitry Baryshkov wrote: > The mdp_clk_src clock should not be turned off. Instead it should be > 'parked' to the XO, as most of other mdp_clk_src clocks. Fix that by > using the clk_rcg2_shared_ops. > > Applied, thanks! [2/2] clk: qcom: mmcc-msm8974: fix MDSS_GDSC power flags commit: 4e13c7a55cf752887f2b8d8008711dbbc64ea796 Best regards,
diff --git a/drivers/clk/qcom/mmcc-msm8974.c b/drivers/clk/qcom/mmcc-msm8974.c index 4273fce9a4a4..aa29c79fcd55 100644 --- a/drivers/clk/qcom/mmcc-msm8974.c +++ b/drivers/clk/qcom/mmcc-msm8974.c @@ -485,7 +485,7 @@ static struct clk_rcg2 mdp_clk_src = { .name = "mdp_clk_src", .parent_data = mmcc_xo_mmpll0_dsi_hdmi_gpll0, .num_parents = ARRAY_SIZE(mmcc_xo_mmpll0_dsi_hdmi_gpll0), - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_shared_ops, }, };
The mdp_clk_src clock should not be turned off. Instead it should be 'parked' to the XO, as most of other mdp_clk_src clocks. Fix that by using the clk_rcg2_shared_ops. Fixes: d8b212014e69 ("clk: qcom: Add support for MSM8974's multimedia clock controller (MMCC)") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/clk/qcom/mmcc-msm8974.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)