| Message ID | 20230519090219.15925-4-quic_devipriy@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add PCIe support for IPQ9574 | expand |
On Fri, May 19, 2023 at 02:32:16PM +0530, Devi Priya wrote: > Add bindings for PCIe hosts on IPQ9574 platform and allow > msi-parent property. > Why can't you use existing "msi-map" property instead of "msi-parent"? - Mani > Signed-off-by: Devi Priya <quic_devipriy@quicinc.com> > --- > Changes in V4: > - Dropped msi-parent from anyOf: as msi-parent and msi-map > cannot coexist and added it specific to ipq9574 > > .../devicetree/bindings/pci/qcom,pcie.yaml | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index 81971be4e554..af5c7a390df1 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -26,6 +26,7 @@ properties: > - qcom,pcie-ipq8064-v2 > - qcom,pcie-ipq8074 > - qcom,pcie-ipq8074-gen3 > + - qcom,pcie-ipq9574 > - qcom,pcie-msm8996 > - qcom,pcie-qcs404 > - qcom,pcie-sa8540p > @@ -113,6 +114,8 @@ properties: > power-domains: > maxItems: 1 > > + msi-parent: true > + > perst-gpios: > description: GPIO controlled connection to PERST# signal > maxItems: 1 > @@ -171,6 +174,7 @@ allOf: > enum: > - qcom,pcie-ipq6018 > - qcom,pcie-ipq8074-gen3 > + - qcom,pcie-ipq9574 > then: > properties: > reg: > @@ -382,6 +386,39 @@ allOf: > - const: ahb # AHB Reset > - const: axi_m_sticky # AXI Master Sticky reset > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,pcie-ipq9574 > + then: > + properties: > + clocks: > + minItems: 6 > + maxItems: 6 > + clock-names: > + items: > + - const: ahb # AHB clock > + - const: aux # Auxiliary clock > + - const: axi_m # AXI Master clock > + - const: axi_s # AXI Slave clock > + - const: axi_bridge # AXI bridge clock > + - const: rchng > + resets: > + minItems: 8 > + maxItems: 8 > + reset-names: > + items: > + - const: pipe # PIPE reset > + - const: sticky # Core Sticky reset > + - const: axi_s_sticky # AXI Slave Sticky reset > + - const: axi_s # AXI Slave reset > + - const: axi_m_sticky # AXI Master Sticky reset > + - const: axi_m # AXI Master reset > + - const: aux # AUX Reset > + - const: ahb # AHB Reset > + > - if: > properties: > compatible: > @@ -767,6 +804,7 @@ allOf: > - qcom,pcie-ipq8064v2 > - qcom,pcie-ipq8074 > - qcom,pcie-ipq8074-gen3 > + - qcom,pcie-ipq9574 > - qcom,pcie-qcs404 > then: > required: > @@ -862,6 +900,16 @@ allOf: > items: > - const: msi > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,pcie-ipq9574 > + then: > + required: > + - msi-parent > + > unevaluatedProperties: false > > examples: > -- > 2.17.1 >
On 5/28/2023 7:47 PM, Manivannan Sadhasivam wrote: > On Fri, May 19, 2023 at 02:32:16PM +0530, Devi Priya wrote: >> Add bindings for PCIe hosts on IPQ9574 platform and allow >> msi-parent property. >> > > Why can't you use existing "msi-map" property instead of "msi-parent"? > > - Mani Sure, will update. Thanks, Devi Priya > >> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com> >> --- >> Changes in V4: >> - Dropped msi-parent from anyOf: as msi-parent and msi-map >> cannot coexist and added it specific to ipq9574 >> >> .../devicetree/bindings/pci/qcom,pcie.yaml | 48 +++++++++++++++++++ >> 1 file changed, 48 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> index 81971be4e554..af5c7a390df1 100644 >> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> @@ -26,6 +26,7 @@ properties: >> - qcom,pcie-ipq8064-v2 >> - qcom,pcie-ipq8074 >> - qcom,pcie-ipq8074-gen3 >> + - qcom,pcie-ipq9574 >> - qcom,pcie-msm8996 >> - qcom,pcie-qcs404 >> - qcom,pcie-sa8540p >> @@ -113,6 +114,8 @@ properties: >> power-domains: >> maxItems: 1 >> >> + msi-parent: true >> + >> perst-gpios: >> description: GPIO controlled connection to PERST# signal >> maxItems: 1 >> @@ -171,6 +174,7 @@ allOf: >> enum: >> - qcom,pcie-ipq6018 >> - qcom,pcie-ipq8074-gen3 >> + - qcom,pcie-ipq9574 >> then: >> properties: >> reg: >> @@ -382,6 +386,39 @@ allOf: >> - const: ahb # AHB Reset >> - const: axi_m_sticky # AXI Master Sticky reset >> >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,pcie-ipq9574 >> + then: >> + properties: >> + clocks: >> + minItems: 6 >> + maxItems: 6 >> + clock-names: >> + items: >> + - const: ahb # AHB clock >> + - const: aux # Auxiliary clock >> + - const: axi_m # AXI Master clock >> + - const: axi_s # AXI Slave clock >> + - const: axi_bridge # AXI bridge clock >> + - const: rchng >> + resets: >> + minItems: 8 >> + maxItems: 8 >> + reset-names: >> + items: >> + - const: pipe # PIPE reset >> + - const: sticky # Core Sticky reset >> + - const: axi_s_sticky # AXI Slave Sticky reset >> + - const: axi_s # AXI Slave reset >> + - const: axi_m_sticky # AXI Master Sticky reset >> + - const: axi_m # AXI Master reset >> + - const: aux # AUX Reset >> + - const: ahb # AHB Reset >> + >> - if: >> properties: >> compatible: >> @@ -767,6 +804,7 @@ allOf: >> - qcom,pcie-ipq8064v2 >> - qcom,pcie-ipq8074 >> - qcom,pcie-ipq8074-gen3 >> + - qcom,pcie-ipq9574 >> - qcom,pcie-qcs404 >> then: >> required: >> @@ -862,6 +900,16 @@ allOf: >> items: >> - const: msi >> >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,pcie-ipq9574 >> + then: >> + required: >> + - msi-parent >> + >> unevaluatedProperties: false >> >> examples: >> -- >> 2.17.1 >> >
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index 81971be4e554..af5c7a390df1 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -26,6 +26,7 @@ properties: - qcom,pcie-ipq8064-v2 - qcom,pcie-ipq8074 - qcom,pcie-ipq8074-gen3 + - qcom,pcie-ipq9574 - qcom,pcie-msm8996 - qcom,pcie-qcs404 - qcom,pcie-sa8540p @@ -113,6 +114,8 @@ properties: power-domains: maxItems: 1 + msi-parent: true + perst-gpios: description: GPIO controlled connection to PERST# signal maxItems: 1 @@ -171,6 +174,7 @@ allOf: enum: - qcom,pcie-ipq6018 - qcom,pcie-ipq8074-gen3 + - qcom,pcie-ipq9574 then: properties: reg: @@ -382,6 +386,39 @@ allOf: - const: ahb # AHB Reset - const: axi_m_sticky # AXI Master Sticky reset + - if: + properties: + compatible: + contains: + enum: + - qcom,pcie-ipq9574 + then: + properties: + clocks: + minItems: 6 + maxItems: 6 + clock-names: + items: + - const: ahb # AHB clock + - const: aux # Auxiliary clock + - const: axi_m # AXI Master clock + - const: axi_s # AXI Slave clock + - const: axi_bridge # AXI bridge clock + - const: rchng + resets: + minItems: 8 + maxItems: 8 + reset-names: + items: + - const: pipe # PIPE reset + - const: sticky # Core Sticky reset + - const: axi_s_sticky # AXI Slave Sticky reset + - const: axi_s # AXI Slave reset + - const: axi_m_sticky # AXI Master Sticky reset + - const: axi_m # AXI Master reset + - const: aux # AUX Reset + - const: ahb # AHB Reset + - if: properties: compatible: @@ -767,6 +804,7 @@ allOf: - qcom,pcie-ipq8064v2 - qcom,pcie-ipq8074 - qcom,pcie-ipq8074-gen3 + - qcom,pcie-ipq9574 - qcom,pcie-qcs404 then: required: @@ -862,6 +900,16 @@ allOf: items: - const: msi + - if: + properties: + compatible: + contains: + enum: + - qcom,pcie-ipq9574 + then: + required: + - msi-parent + unevaluatedProperties: false examples:
Add bindings for PCIe hosts on IPQ9574 platform and allow msi-parent property. Signed-off-by: Devi Priya <quic_devipriy@quicinc.com> --- Changes in V4: - Dropped msi-parent from anyOf: as msi-parent and msi-map cannot coexist and added it specific to ipq9574 .../devicetree/bindings/pci/qcom,pcie.yaml | 48 +++++++++++++++++++ 1 file changed, 48 insertions(+)