| Message ID | 20230614012913.122220-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [-next,1/3] clk: sprd: composite: Fix unsigned comparison with less than zero | expand |
diff --git a/drivers/clk/sprd/composite.c b/drivers/clk/sprd/composite.c index d3a852720c07..e4d22d8f113f 100644 --- a/drivers/clk/sprd/composite.c +++ b/drivers/clk/sprd/composite.c @@ -13,7 +13,7 @@ static int sprd_comp_determine_rate(struct clk_hw *hw, struct clk_rate_request *req) { struct sprd_comp *cc = hw_to_sprd_comp(hw); - unsigned long rate; + long rate; rate = sprd_div_helper_round_rate(&cc->common, &cc->div, req->rate, &req->best_parent_rate);
The return value of the sprd_div_helper_round_rate() is long. However, the return value is being assigned to an unsigned long variable 'rate', so making 'rate' to long. silence the warning: ./drivers/clk/sprd/composite.c:20:5-9: WARNING: Unsigned expression compared with zero: rate < 0 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5519 Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/clk/sprd/composite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)