diff mbox series

[v2,1/2] clk: vc5: Use i2c_get_match_data() instead of device_get_match_data()

Message ID 20230721070019.96627-2-biju.das.jz@bp.renesas.com (mailing list archive)
State Accepted, archived
Headers show
Series Use i2c_get_match_data() for versa{5,7} drivers | expand

Commit Message

Biju Das July 21, 2023, 7 a.m. UTC 
The device_get_match_data(), is to get match data for firmware interfaces
such as just OF/ACPI. This driver has I2C matching table as well. Use
i2c_get_match_data() to get match data for I2C, ACPI and DT-based
matching.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v1->v2:
 * Added Rb tags from Geert and Marek.
 * Removed error check as all tables have data pointers.
 * Retained Rb tag as the change is trivial.
---
 drivers/clk/clk-versaclock5.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Luca Ceresoli July 21, 2023, 8:28 a.m. UTC | #1 
Hello Biju,

On Fri, 21 Jul 2023 08:00:18 +0100
Biju Das <biju.das.jz@bp.renesas.com> wrote:

> The device_get_match_data(), is to get match data for firmware interfaces
> such as just OF/ACPI. This driver has I2C matching table as well. Use
> i2c_get_match_data() to get match data for I2C, ACPI and DT-based
> matching.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v1->v2:
>  * Added Rb tags from Geert and Marek.
>  * Removed error check as all tables have data pointers.
>  * Retained Rb tag as the change is trivial.

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Stephen Boyd Aug. 22, 2023, 8:12 p.m. UTC | #2 
Quoting Biju Das (2023-07-21 00:00:18)
> The device_get_match_data(), is to get match data for firmware interfaces
> such as just OF/ACPI. This driver has I2C matching table as well. Use
> i2c_get_match_data() to get match data for I2C, ACPI and DT-based
> matching.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---

Applied to clk-next
diff mbox series

Patch

diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c
index 72b432f93b5f..17cbb30d20ad 100644
--- a/drivers/clk/clk-versaclock5.c
+++ b/drivers/clk/clk-versaclock5.c
@@ -955,7 +955,7 @@  static int vc5_probe(struct i2c_client *client)
 
 	i2c_set_clientdata(client, vc5);
 	vc5->client = client;
-	vc5->chip_info = device_get_match_data(&client->dev);
+	vc5->chip_info = i2c_get_match_data(client);
 
 	vc5->pin_xin = devm_clk_get(&client->dev, "xin");
 	if (PTR_ERR(vc5->pin_xin) == -EPROBE_DEFER)