| Message ID | 20231031020159.587686-1-suhui@nfschina.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | clk: si5341: fix an error code problem in si5341_output_clk_set_rate | expand |
FWIW, you have my gratitude... Acked-By: Mike Looijmans <mike.looijmans@topic.nl> One remark, maybe just "return regmap_...." straightaway and skip the "err = " assignment. M. On 31-10-2023 03:02, Su Hui wrote: > regmap_bulk_write() return zero or negative error code, return 'err' > rather than '0'. > > Fixes: 3044a860fd09 ("clk: Add Si5341/Si5340 driver") > Signed-off-by: Su Hui <suhui@nfschina.com> > --- > drivers/clk/clk-si5341.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c > index 9599857842c7..9b1cc5a83b5b 100644 > --- a/drivers/clk/clk-si5341.c > +++ b/drivers/clk/clk-si5341.c > @@ -898,7 +898,7 @@ static int si5341_output_clk_set_rate(struct clk_hw *hw, unsigned long rate, > err = regmap_bulk_write(output->data->regmap, > SI5341_OUT_R_REG(output), r, 3); > > - return 0; > + return err; > } > > static int si5341_output_reparent(struct clk_si5341_output *output, u8 index)
diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c index 9599857842c7..9b1cc5a83b5b 100644 --- a/drivers/clk/clk-si5341.c +++ b/drivers/clk/clk-si5341.c @@ -898,7 +898,7 @@ static int si5341_output_clk_set_rate(struct clk_hw *hw, unsigned long rate, err = regmap_bulk_write(output->data->regmap, SI5341_OUT_R_REG(output), r, 3); - return 0; + return err; } static int si5341_output_reparent(struct clk_si5341_output *output, u8 index)
regmap_bulk_write() return zero or negative error code, return 'err' rather than '0'. Fixes: 3044a860fd09 ("clk: Add Si5341/Si5340 driver") Signed-off-by: Su Hui <suhui@nfschina.com> --- drivers/clk/clk-si5341.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)