| Message ID | 20231101031633.996124-1-suhui@nfschina.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v2] clk: si5341: fix an error code problem in si5341_output_clk_set_rate | expand |
Quoting Su Hui (2023-10-31 20:16:36) > regmap_bulk_write() return zero or negative error code, return the value > of regmap_bulk_write() rather than '0'. > > Fixes: 3044a860fd09 ("clk: Add Si5341/Si5340 driver") > Acked-by: Mike Looijmans <mike.looijmans@topic.nl> > Signed-off-by: Su Hui <suhui@nfschina.com> > --- Applied to clk-next
diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c index 9599857842c7..2920fe2e5e8b 100644 --- a/drivers/clk/clk-si5341.c +++ b/drivers/clk/clk-si5341.c @@ -895,10 +895,8 @@ static int si5341_output_clk_set_rate(struct clk_hw *hw, unsigned long rate, r[0] = r_div ? (r_div & 0xff) : 1; r[1] = (r_div >> 8) & 0xff; r[2] = (r_div >> 16) & 0xff; - err = regmap_bulk_write(output->data->regmap, + return regmap_bulk_write(output->data->regmap, SI5341_OUT_R_REG(output), r, 3); - - return 0; } static int si5341_output_reparent(struct clk_si5341_output *output, u8 index)
regmap_bulk_write() return zero or negative error code, return the value of regmap_bulk_write() rather than '0'. Fixes: 3044a860fd09 ("clk: Add Si5341/Si5340 driver") Acked-by: Mike Looijmans <mike.looijmans@topic.nl> Signed-off-by: Su Hui <suhui@nfschina.com> --- drivers/clk/clk-si5341.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)