| Message ID | 20240110-clk-th1520-v1-2-8b0682567984@tenstorrent.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | clk: thead: add support for T-HEAD TH1520 AP clock controller | expand |
On 10/01/2024 17:35, Drew Fustini wrote: > From: Yangtao Li <frank.li@vivo.com> > > Document devicetree bindings for the T-HEAD TH1520 AP sub-system > clock controller. > > Signed-off-by: Yangtao Li <frank.li@vivo.com> > [add link to reference manual] > [fixed dt_binding_check warnings] > [revised commit description] > Signed-off-by: Drew Fustini <dfustini@tenstorrent.com> > --- > .../bindings/clock/thead,th1520-clk-ap.yaml | 65 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 66 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml b/Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml > new file mode 100644 > index 000000000000..53e7802a4ad7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml If this is for the header, then two patches should be squashed and you should use the same name for the header. > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/thead,th1520-clk-ap.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: T-HEAD TH1520 AP sub-system clock controller > + > +description: | > + The T-HEAD TH1520 AP sub-system clock controller configures the > + CPU, DPU, GMAC and TEE PLLs. > + > + SoC reference manual > + https://openbeagle.org/beaglev-ahead/beaglev-ahead/-/blob/main/docs/TH1520%20System%20User%20Manual.pdf > + > +maintainers: > + - Jisheng Zhang <jszhang@kernel.org> > + - Wei Fu <wefu@redhat.com> > + - Yangtao Li <frank.li@vivo.com> > + > +properties: > + compatible: > + const: thead,th1520-clk-ap > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: main oscillator (24MHz) > + > + clock-names: > + items: > + - const: osc > + > + "#clock-cells": > + const: 1 > + description: > + See <dt-bindings/clock/thead,th1520-clk.h> for valid indices. > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - "#clock-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/thead,th1520-clk.h> > + soc { > + Drop redundant blank line. > + #address-cells = <2>; > + #size-cells = <2>; > + > + clk: clock-controller@ffef010000 { Drop unused label. Best regards, Krzysztof
On 10/01/2024 17:35, Drew Fustini wrote: > From: Yangtao Li <frank.li@vivo.com> > > Document devicetree bindings for the T-HEAD TH1520 AP sub-system > clock controller. > > Signed-off-by: Yangtao Li <frank.li@vivo.com> > [add link to reference manual] > [fixed dt_binding_check warnings] > [revised commit description] > Signed-off-by: Drew Fustini <dfustini@tenstorrent.com> Emails bounced: "Your message wasn't delivered to dfustini@tenstorrent.org because the domain tenstorrent.org couldn't be found. Check for typos or unnecessary spaces and try again." Best regards, Krzysztof
On Wed, Jan 10, 2024 at 08:35:16AM -0800, Drew Fustini wrote: > From: Yangtao Li <frank.li@vivo.com> > > Document devicetree bindings for the T-HEAD TH1520 AP sub-system > clock controller. > > Signed-off-by: Yangtao Li <frank.li@vivo.com> > [add link to reference manual] > [fixed dt_binding_check warnings] > [revised commit description] btw, can you remove this sort of thing from the commit message and put it in the changelog instead? Cheers, Conor. > Signed-off-by: Drew Fustini <dfustini@tenstorrent.com>
diff --git a/Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml b/Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml new file mode 100644 index 000000000000..53e7802a4ad7 --- /dev/null +++ b/Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml @@ -0,0 +1,65 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/thead,th1520-clk-ap.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: T-HEAD TH1520 AP sub-system clock controller + +description: | + The T-HEAD TH1520 AP sub-system clock controller configures the + CPU, DPU, GMAC and TEE PLLs. + + SoC reference manual + https://openbeagle.org/beaglev-ahead/beaglev-ahead/-/blob/main/docs/TH1520%20System%20User%20Manual.pdf + +maintainers: + - Jisheng Zhang <jszhang@kernel.org> + - Wei Fu <wefu@redhat.com> + - Yangtao Li <frank.li@vivo.com> + +properties: + compatible: + const: thead,th1520-clk-ap + + reg: + maxItems: 1 + + clocks: + items: + - description: main oscillator (24MHz) + + clock-names: + items: + - const: osc + + "#clock-cells": + const: 1 + description: + See <dt-bindings/clock/thead,th1520-clk.h> for valid indices. + +required: + - compatible + - reg + - clocks + - clock-names + - "#clock-cells" + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/thead,th1520-clk.h> + soc { + + #address-cells = <2>; + #size-cells = <2>; + + clk: clock-controller@ffef010000 { + compatible = "thead,th1520-clk-ap"; + reg = <0xff 0xef010000 0x0 0x1000>; + clocks = <&osc>; + clock-names = "osc"; + #clock-cells = <1>; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index a52dbf3c5606..dd2398512fc0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18856,6 +18856,7 @@ M: Guo Ren <guoren@kernel.org> M: Fu Wei <wefu@redhat.com> L: linux-riscv@lists.infradead.org S: Maintained +F: Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml F: arch/riscv/boot/dts/thead/ F: include/dt-bindings/clock/thead,th1520-clk.h