| Message ID | 20240318053555.20405-2-quic_tdas@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add updates for clock controllers to support QCM6490 | expand |
On Mon Mar 18, 2024 at 6:35 AM CET, Taniya Das wrote: > Add the new QCM6490 compatible to support the reset functionality for > Low Power Audio subsystem. > > Signed-off-by: Taniya Das <quic_tdas@quicinc.com> > --- > .../devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml > index deee5423d66e..861b41933525 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml > @@ -30,6 +30,7 @@ properties: > - qcom,sc7280-lpassaudiocc > - qcom,sc7280-lpasscorecc > - qcom,sc7280-lpasshm > + - qcom,qcm6490-lpassaudiocc So QCM6490 and SM7325 and SC7280 with non-CrOS firmware (maybe some WoA devices?) are supposed to use qcom,qcm6490-lpassaudiocc then? Is this what is intended? Regards Luca > > power-domains: > maxItems: 1 > -- > 2.17.1
On 18/03/2024 06:35, Taniya Das wrote: > Add the new QCM6490 compatible to support the reset functionality for > Low Power Audio subsystem. > > Signed-off-by: Taniya Das <quic_tdas@quicinc.com> > --- > .../devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml > index deee5423d66e..861b41933525 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml > @@ -30,6 +30,7 @@ properties: > - qcom,sc7280-lpassaudiocc > - qcom,sc7280-lpasscorecc > - qcom,sc7280-lpasshm > + - qcom,qcm6490-lpassaudiocc Don't add stuff at the end, but keep order. This applies everywhere... I am pretty sure you got such comment from me in the past. Best regards, Krzysztof
On 18/03/2024 06:35, Taniya Das wrote: > Add the new QCM6490 compatible to support the reset functionality for > Low Power Audio subsystem. > > Signed-off-by: Taniya Das <quic_tdas@quicinc.com> > --- > .../devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml > index deee5423d66e..861b41933525 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml > @@ -30,6 +30,7 @@ properties: > - qcom,sc7280-lpassaudiocc > - qcom,sc7280-lpasscorecc > - qcom,sc7280-lpasshm > + - qcom,qcm6490-lpassaudiocc > ... and open the binding, so you will see how incomplete this is. Best regards, Krzysztof
On 3/18/2024 12:41 PM, Luca Weiss wrote: > On Mon Mar 18, 2024 at 6:35 AM CET, Taniya Das wrote: >> Add the new QCM6490 compatible to support the reset functionality for >> Low Power Audio subsystem. >> >> Signed-off-by: Taniya Das <quic_tdas@quicinc.com> >> --- >> .../devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml >> index deee5423d66e..861b41933525 100644 >> --- a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml >> +++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml >> @@ -30,6 +30,7 @@ properties: >> - qcom,sc7280-lpassaudiocc >> - qcom,sc7280-lpasscorecc >> - qcom,sc7280-lpasshm >> + - qcom,qcm6490-lpassaudiocc > > So QCM6490 and SM7325 and SC7280 with non-CrOS firmware (maybe some WoA > devices?) are supposed to use qcom,qcm6490-lpassaudiocc then? Is this > what is intended? > Sorry for the very late response on this thread, On QCM6490-IPD and QCS690-RB3Gen2 boards, will require only reset functionality for Low Power Audio subsystem and other clock controller functionality is not supported from HLOS, as LPASS firmware takes care of it. Hence added new compatible to support only resets. > Regards > Luca > >> >> power-domains: >> maxItems: 1 >> -- >> 2.17.1 >
On 3/18/2024 1:17 PM, Krzysztof Kozlowski wrote: > On 18/03/2024 06:35, Taniya Das wrote: >> Add the new QCM6490 compatible to support the reset functionality for >> Low Power Audio subsystem. >> >> Signed-off-by: Taniya Das <quic_tdas@quicinc.com> >> --- >> .../devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml >> index deee5423d66e..861b41933525 100644 >> --- a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml >> +++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml >> @@ -30,6 +30,7 @@ properties: >> - qcom,sc7280-lpassaudiocc >> - qcom,sc7280-lpasscorecc >> - qcom,sc7280-lpasshm >> + - qcom,qcm6490-lpassaudiocc > > Don't add stuff at the end, but keep order. This applies everywhere... I > am pretty sure you got such comment from me in the past. > Apologies to not able to respond on this earlier. I will update this patch in the next series. This patch series seemed to have been blocked on the other fixes, so I intend to separate out the patches. > Best regards, > Krzysztof >
On Fri May 31, 2024 at 11:28 AM CEST, Taniya Das wrote: > > > On 3/18/2024 12:41 PM, Luca Weiss wrote: > > On Mon Mar 18, 2024 at 6:35 AM CET, Taniya Das wrote: > >> Add the new QCM6490 compatible to support the reset functionality for > >> Low Power Audio subsystem. > >> > >> Signed-off-by: Taniya Das <quic_tdas@quicinc.com> > >> --- > >> .../devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml > >> index deee5423d66e..861b41933525 100644 > >> --- a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml > >> +++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml > >> @@ -30,6 +30,7 @@ properties: > >> - qcom,sc7280-lpassaudiocc > >> - qcom,sc7280-lpasscorecc > >> - qcom,sc7280-lpasshm > >> + - qcom,qcm6490-lpassaudiocc > > > > So QCM6490 and SM7325 and SC7280 with non-CrOS firmware (maybe some WoA > > devices?) are supposed to use qcom,qcm6490-lpassaudiocc then? Is this > > what is intended? > > > > Sorry for the very late response on this thread, On QCM6490-IPD and > QCS690-RB3Gen2 boards, will require only reset functionality for Low > Power Audio subsystem and other clock controller functionality is not > supported from HLOS, as LPASS firmware takes care of it. > Hence added new compatible to support only resets. Hi Taniya, My question was more if the *qcm6490* compatible should then also be used on regular SM7325 devices for example since they'll reuse sc7280.dtsi just like qc[ms]6490. And also Windows-on-ARM SC7280 devices presumably have these clocks locked behind the LPASS firmware so then also such a device would use the qcm6490 compatible? Regards Luca > > > Regards > > Luca > > > >> > >> power-domains: > >> maxItems: 1 > >> -- > >> 2.17.1 > >
diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml index deee5423d66e..861b41933525 100644 --- a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml @@ -30,6 +30,7 @@ properties: - qcom,sc7280-lpassaudiocc - qcom,sc7280-lpasscorecc - qcom,sc7280-lpasshm + - qcom,qcm6490-lpassaudiocc power-domains: maxItems: 1
Add the new QCM6490 compatible to support the reset functionality for Low Power Audio subsystem. Signed-off-by: Taniya Das <quic_tdas@quicinc.com> --- .../devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml | 1 + 1 file changed, 1 insertion(+) -- 2.17.1