[v24,4/4] dt-binding: clock: remove nuvoton npcm845-clk bindings

Commit Message

Tomer Maimon May 9, 2024, 7:24 p.m. UTC

Remove nuvoton,npcm845-clk binding since the NPCM8xx clock driver
using the auxiliary device framework and not the device tree framework.

Signed-off-by: Tomer Maimon <[e-mail]>
---
 .../bindings/clock/nuvoton,npcm845-clk.yaml   | 49 -------------------
 1 file changed, 49 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml

Comments

Rob Herring May 13, 2024, 3:53 p.m. UTC | #1

On Thu, May 09, 2024 at 10:24:11PM +0300, Tomer Maimon wrote:
> Remove nuvoton,npcm845-clk binding since the NPCM8xx clock driver
> using the auxiliary device framework and not the device tree framework.

Again, this is an ABI break. Changing driver architecture for 1 OS is 
not a reason to change DT.

Rob

Tomer Maimon May 16, 2024, 9:44 a.m. UTC | #2

Hi Rob,

Thanks for your comment.

On Mon, 13 May 2024 at 18:53, Rob Herring <[e-mail]> wrote:
>
> On Thu, May 09, 2024 at 10:24:11PM +0300, Tomer Maimon wrote:
> > Remove nuvoton,npcm845-clk binding since the NPCM8xx clock driver
> > using the auxiliary device framework and not the device tree framework.
>
> Again, this is an ABI break. Changing driver architecture for 1 OS is
> not a reason to change DT.
Is it an ABI break even if the NPCM8xx clock driver hasn't upstream
the kernel vanilla yet?

I thought that since the NPCM8xx clock driver hasn't upstream the
kernel vanilla yet and and in the latest NPCM8xx clock driver patch
the NPCM8xx clock driver.
using auxiliary device framework instead of DT we should remove the
nuvoton,npcm845-clk.yaml file.
https://patchwork.kernel.org/project/linux-clk/patch/[e-mail]/

>
> Rob

Thanks,

Tomer

Patch

diff --git a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml
deleted file mode 100644
index b901ca13cd25..000000000000
--- a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml
+++ /dev/null
@@ -1,49 +0,0 @@ 
-# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
-%YAML 1.2
----
-$id: http://devicetree.org/schemas/clock/nuvoton,npcm845-clk.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: Nuvoton NPCM8XX Clock Controller
-
-maintainers:
-  - Tomer Maimon <[e-mail]>
-
-description: |
-  Nuvoton Arbel BMC NPCM8XX contains an integrated clock controller, which
-  generates and supplies clocks to all modules within the BMC.
-
-properties:
-  compatible:
-    enum:
-      - nuvoton,npcm845-clk
-
-  reg:
-    maxItems: 1
-
-  '#clock-cells':
-    const: 1
-    description:
-      See include/dt-bindings/clock/nuvoton,npcm8xx-clock.h for the full
-      list of NPCM8XX clock IDs.
-
-required:
-  - compatible
-  - reg
-  - '#clock-cells'
-
-additionalProperties: false
-
-examples:
-  - |
-    ahb {
-        #address-cells = <2>;
-        #size-cells = <2>;
-
-        clock-controller@f0801000 {
-            compatible = "nuvoton,npcm845-clk";
-            reg = <0x0 0xf0801000 0x0 0x1000>;
-            #clock-cells = <1>;
-        };
-    };
-...