From patchwork Tue May 28 00:14:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Holland X-Patchwork-Id: 13675948 Received: from mail-oo1-f45.google.com (mail-oo1-f45.google.com [209.85.161.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A363364 for ; Tue, 28 May 2024 00:14:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716855277; cv=none; b=UV+175GppzYKDGdo0/MVMXGfMvW1QcKIDMNKnXujM5YZzTmG6m1a3CoX5asqYX0PmQcawUxyC5dGGFAlQvVm1YE3a//I9WJGp8+g0ivtUx9qeadnM/LK+4O9mR8cm3jS740j/+oXpsNfSBkB4ssX+kDTEeg1PG8S0FMS1BowWiI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716855277; c=relaxed/simple; bh=E/egdz2CGqojoAgfoOnzR3hlfAj67B/HxDS0QDBOeis=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=U8sIl7W4eLQeOXCz8zz+ActbdtgGtTvgy9OprdpJjmkCS86kxwV0vmkejpd2qnKdYWg57wJ+OMHlVeMiVxssj8Grrhn+UmOshwp22tcxmq7rfpQ+Pa/cQ6aEdselVayFTIwBcnOz22rB44gVCtHOeudO+v0PUEg1JfkR8Qc7yIU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=MrQUdse+; arc=none smtp.client-ip=209.85.161.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="MrQUdse+" Received: by mail-oo1-f45.google.com with SMTP id 006d021491bc7-5b9794dad09so134960eaf.3 for ; Mon, 27 May 2024 17:14:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1716855274; x=1717460074; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BtU4Y/eRQ2OBmokCMjLNZWabCaVyZYO3DB4JfpF3nAY=; b=MrQUdse+XQP95f2tKt9tyxCqtoWZwjkR+8CuSaGrR95CXfiYs67HQKPVWnCZ1qs1LN V/e5qUMvwwzPwLe0nW8HvOBRmcA5Y0Km+33s0WC1VOdYQmPRuYm8SIC/wRkB4X/rObi6 CRwK9qr0P8zgrPXKv/05StKJTMU+YbAbkAvqghOiQo6jyLsQcgznNkFMuiRnHVQZi/+c RdxQpKzT+kJNF4zxqOvFslEKEN/aWU0g5ti9A+5KglcwVkow+NQN73mIFfb9BRZZjkjP lU0y1pVk5W60wIfCshqwHcQfmFRqecrjDWAPSarMXnxhKDBKdJ6G5gTNsmAzY6ymUEQJ uKkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716855274; x=1717460074; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BtU4Y/eRQ2OBmokCMjLNZWabCaVyZYO3DB4JfpF3nAY=; b=aPDhHqslBvNh8TRBWKX613s+0IusRJBA4jLodrOvXihOxp//9JdngRjE+G3TleChrK NYLfWFhkM2aPk7IhVfCzvRUT4XFEKVeXFSIx9cE4xMymrhbe9D3ixWEsCB1eP653QjMx AiTgmcQYkgv7o0t4Ny0tEI722Vsg97nnelNiSKPcQnyxPWwucdyqnI8xyobTaKv+ZJ2O HF+9K+pCwAQsJqVOgm0NZs9vykDLFGNS4Ddw8r0JbYVz6vTbxwelq26nSsRp1ndBWWdW J7opJjMjBnoj61iCSYiIOcsAvfcwFaB+g2L1O5rwLl0tD8d5dg/tnro02f+nqqIi8l8O E+CA== X-Forwarded-Encrypted: i=1; AJvYcCVMRYNBtgZomF3tfCCv9G4M3o1PaeymdbCJ1tE4TwxB9IurBSs4QvVVZZy3q0wjlLD1jb1NlKmU0KOT4xKrpYSGcNEHZJc1RjZ4 X-Gm-Message-State: AOJu0YzeKFCIh5kFCQ4m3/6XoHtrj+vDSB8ixu5IKtucjGa9VtS85src 1zKIC2CBXKEUqV7LbrhSb/atdH/SCiNeDz0T4FK4O71+s2unTMGWurfR2MoJs4g= X-Google-Smtp-Source: AGHT+IGxwhLw6BTrQ2V9xcN9eZHUbmtBeH0DBK7jsO/MxRI72pCJIA3N2I2HkR6izN4ncWAVY0y9bw== X-Received: by 2002:a05:6358:4688:b0:192:ce79:b64 with SMTP id e5c5f4694b2df-197e50f4911mr1498831955d.9.1716855274176; Mon, 27 May 2024 17:14:34 -0700 (PDT) Received: from sw06.internal.sifive.com ([4.53.31.132]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-682226fc4dcsm6536043a12.42.2024.05.27.17.14.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 17:14:33 -0700 (PDT) From: Samuel Holland To: Stephen Boyd Cc: Samuel Holland , Guenter Roeck , Russell King , AngeloGioacchino Del Regno , Dinh Nguyen , Krzysztof Kozlowski , Michael Turquette , Paul Walmsley , Rob Herring , "Russell King (Oracle)" , Yang Li , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH] clk: sifive: Do not register clkdevs for PRCI clocks Date: Mon, 27 May 2024 17:14:12 -0700 Message-ID: <20240528001432.1200403-1-samuel.holland@sifive.com> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 These clkdevs were unnecessary, because systems using this driver always look up clocks using the devicetree. And as Russell King points out[1], since the provided device name was truncated, lookups via clkdev would never match. Recently, commit 8d532528ff6a ("clkdev: report over-sized strings when creating clkdev entries") caused clkdev registration to fail due to the truncation, and this now prevents the driver from probing. Fix the driver by removing the clkdev registration. Link: https://lore.kernel.org/linux-clk/ZkfYqj+OcAxd9O2t@shell.armlinux.org.uk/ [1] Fixes: 30b8e27e3b58 ("clk: sifive: add a driver for the SiFive FU540 PRCI IP block") Fixes: 8d532528ff6a ("clkdev: report over-sized strings when creating clkdev entries") Reported-by: Guenter Roeck Closes: https://lore.kernel.org/linux-clk/7eda7621-0dde-4153-89e4-172e4c095d01@roeck-us.net/ Suggested-by: Russell King Signed-off-by: Samuel Holland --- This change fixes v6.10-rc1 boot on HiFive Unmatched. drivers/clk/sifive/sifive-prci.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/clk/sifive/sifive-prci.c b/drivers/clk/sifive/sifive-prci.c index 25b8e1a80ddc..b32a59fe55e7 100644 --- a/drivers/clk/sifive/sifive-prci.c +++ b/drivers/clk/sifive/sifive-prci.c @@ -4,7 +4,6 @@ * Copyright (C) 2020 Zong Li */ -#include #include #include #include @@ -537,13 +536,6 @@ static int __prci_register_clocks(struct device *dev, struct __prci_data *pd, return r; } - r = clk_hw_register_clkdev(&pic->hw, pic->name, dev_name(dev)); - if (r) { - dev_warn(dev, "Failed to register clkdev for %s: %d\n", - init.name, r); - return r; - } - pd->hw_clks.hws[i] = &pic->hw; }